Re: [389-devel] Please review bug 47586: CI tests: test case for 47490

[thierry bordaz <tbordaz@xxxxxxxxxx>]

On 11/15/2013 04:16 PM, Roberto Polli wrote:

On Friday 15 November 2013 15:18:26 thierry bordaz wrote:

https://fedorahosted.org/389/attachment/ticket/47586/0001-Ticket-47586-CI-te
sts-test-case-for-47490.patch

1- I'd replace the following:
-from lib389._constants import DN_DM 
+from lib389 import DN_DM 

Files starting with _ are "private" and are just facilities for the developer.
We could consider to rename _constants to constants


2- To isolate testing tools from the library I would put 
args_standalone & co in a proper bugfix harness file/class that we can add to 
lib389, eg:

from lib389.bugfix import args_standalone 
Otherwise people/projects using lib389 will be full of our testing code.

Hi Roberto,

Thanks for reviewing it. I agree that _constants make no sense, I will change that.

I have a question regarding your 2nd point.
Lib389 offers an interface to create an instance 'createInstance'. This function takes a dict as argument containing the description of the instance.
For me implementation of that dict should be done by the lib389 user.
What lib389 can offer, is a dict template with default values.  Is that this template that you recommend to put into lib389.bugfix ?

Note: currently ticket/constant.py contains a arg_standalone. I think it is not a good idea, as simply a arg_template should be provided.

regards
thierry

Peace,
R.

--
389-devel mailing list
389-devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/389-devel