Re: [389-devel] Please review lib389 ticket 47584 (take #2): CI tests: add backup/restore of an instance

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Roberto,
Yes absolutely this is a better choice !! thanks for the tips, I will change the fix

regards
thierry

On 11/06/2013 06:35 PM, Roberto Polli wrote:
You may consider replacing the whole function checkInstanceBackupFS
with the simpler:
 backup_pattern = os.path.join(backupDir, "backup*.tar.gz") 
 return glob.glob(backup_pattern)

It should return an empty list in case of unexistent path

On Wednesday 06 November 2013 18:31:40 thierry bordaz wrote:
Thanks Roberto and Rich for reviewing this.
This second patch takes into account your recommendation to let the
logging mechanism to choose rather that to use 'verbose' flag.

https://fedorahosted.org/389/attachment/ticket/47584/0002-Ticket-47584-CI-te
sts-add-backup-restore-of-an-insta.patch

    

--
389-devel mailing list
389-devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/389-devel

[Index of Archives]     [Fedora Directory Announce]     [Fedora Users]     [Older Fedora Users Mail]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Review]     [Fedora Art]     [Fedora Music]     [Fedora Packaging]     [CentOS]     [Fedora SELinux]     [Big List of Linux Books]     [KDE Users]     [Fedora Art]     [Fedora Docs]

  Powered by Linux