[389-devel] Please review (take 3): #46 and #66

[Noriko Hosoi <nhosoi@xxxxxxxxxx>]

Trac #46 - setup-ds-admin.pl does not like ipv6 only hostnames
https://fedorahosted.org/389/ticket/46
https://fedorahosted.org/389/attachment/ticket/46/0001-Trac-Ticket-46-take-3-setup-ds-admin.pl-does-not-lik.patch

Fixed the code following the suggestions by Rich (Thank you!!)

Fix Description:
Perl functions (gethostbyname, gethostbyaddr) do not support IPv6
addresses.  This patch addes the IPv6 support if an IPv6 enabled
socket module is available.  If Socket::addrinfo subsystem is
found, use getaddrinfo and getnameinfo from the module. If not
and if Socket6 module is available, the module is used.  If both
are not found on the system, the existing non-IPv6 methods are
called.

Trac #66 - 389-ds-base spec file does not have a BuildRequires on gcc-g++
https://fedorahosted.org/389/ticket/66
https://fedorahosted.org/389/attachment/ticket/66/0001-Trac-Ticket-46-and-66.patch

Fix Description:
Adding IPv6 friendly perl packages to Requires list:
  Requires: perl-Socket
or
  Requires: perl-Socket6
depending upon the perl Socket module availability.
Adding gcc-c++ to the build dependency
  BuildRequires: gcc-c++

changelog:
- Ticket #46 - (revised) setup-ds-admin.pl does not like ipv6 only hostnames
- Ticket #66 - 389-ds-base spec file does not have a BuildRequires on gcc-c++

Noriko Hosoi wrote:

https://fedorahosted.org/389/ticket/46

https://fedorahosted.org/389/attachment/ticket/46/0001-Trac-Ticket-46-revised-setup-ds-admin.pl-does-not.patch
Fix Description:
Socket::GetAddrInfo class is not available on all the supported
platforms. Instead, this patch uses Socket6, which has better
supports.

https://fedorahosted.org/389/ticket/46

https://fedorahosted.org/389/attachment/ticket/46/0001-Trac-Ticket-46-setup-ds-admin.pl-does-not-like-ipv6-.patch
git patch file (master)
Fix Description:
Perl functions gethostbyname/gethostbyaddr do not support IPv6
addresses. This patch replaces the obsolete functions with the
ones from Socket::GetAddrInfo.

https://fedorahosted.org/389/attachment/ticket/46/0001-Trac-Ticket-46-setup-ds-admin.pl-does-not-like-ipv6-.2.patch
git patch file for 389-ds-base.spec (master)

Fix Description:
Adding IPv6 friendly perl packages to Requires list:

Requires: perl-Socket-GetAddrInfo
Requires: perl-NetAddr-IP

--
389-devel mailing list
389-devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/389-devel

--
389-devel mailing list
389-devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/389-devel

--
389-devel mailing list
389-devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/389-devel