|
An additional fix is needed for this issue. Your patch fixed
the dna_pre_op() function, but the same issue exists in the
dna_be_txn_pre_op() function. The attached patch takes care of
this. On 03/06/2012 09:30 AM, Rich Megginson wrote:
|
>From 6f8680a94aa721633a18148b44bd28baa72cd4ae Mon Sep 17 00:00:00 2001
From: Nathan Kinder <nkinder@xxxxxxxxxx>
Date: Wed, 7 Mar 2012 06:49:13 -0800
Subject: [PATCH] coverity 12563 Read from pointer after free (fix 2)
The previous commit for coverity issue 12563 fixed the dna_pre_op()
function to avoid reading the target of a freed pointer. This same
fix needs to be made to dna_be_txn_pre_op().
---
ldap/servers/plugins/dna/dna.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/ldap/servers/plugins/dna/dna.c b/ldap/servers/plugins/dna/dna.c
index 84f2a7a..80f722b 100644
--- a/ldap/servers/plugins/dna/dna.c
+++ b/ldap/servers/plugins/dna/dna.c
@@ -3481,6 +3481,7 @@ static int dna_be_txn_pre_op(Slapi_PBlock *pb, int modtype)
slapi_ch_free_string(&value);
slapi_ch_free_string(&new_value);
slapi_ch_array_free(types_to_generate);
+ types_to_generate = NULL;
} else if (types_to_generate) {
slapi_ch_free((void **)&types_to_generate);
}
--
1.7.7.6
-- 389-devel mailing list 389-devel@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/389-devel
