From 31ecec728ada7c50e57c969342bb5a400a9b0c2b Mon Sep 17 00:00:00 2001
From: Rich Megginson <rmeggins@xxxxxxxxxx>
Date: Thu, 16 Feb 2012 08:14:43 -0700
Subject: [PATCH] coverity uninit var and resource leak
12550 Uninitialized pointer read
In dna_update_config_event(): Reads an uninitialized pointer or its target
12549 Resource leak
In referint_thread_func(): Leak of memory or pointers to system resources
---
ldap/servers/plugins/dna/dna.c | 2 +-
ldap/servers/plugins/referint/referint.c | 1 +
2 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/ldap/servers/plugins/dna/dna.c b/ldap/servers/plugins/dna/dna.c
index fedfa50..efb2de4 100644
--- a/ldap/servers/plugins/dna/dna.c
+++ b/ldap/servers/plugins/dna/dna.c
@@ -1271,7 +1271,7 @@ dna_load_host_port()
static void
dna_update_config_event(time_t event_time, void *arg)
{
- Slapi_PBlock *pb;
+ Slapi_PBlock *pb = NULL;
struct configEntry *config_entry = NULL;
PRCList *list = NULL;
char *binddn = (char *)arg;
diff --git a/ldap/servers/plugins/referint/referint.c b/ldap/servers/plugins/referint/referint.c
index 775da59..ee7c781 100644
--- a/ldap/servers/plugins/referint/referint.c
+++ b/ldap/servers/plugins/referint/referint.c
@@ -920,6 +920,7 @@ referint_thread_func(void *arg)
if(plugin_argv == NULL){
slapi_log_error( SLAPI_LOG_FATAL, REFERINT_PLUGIN_SUBSYSTEM,
"referint_thread_func not get args \n" );
+ slapi_pblock_destroy(pb);
return;
}
--
1.7.1
--
389-devel mailing list
389-devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/389-devel
