Re: [389-devel] Please review: fix several compiler warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Nathan Kinder wrote:
> On 09/01/2010 03:51 PM, Rich Megginson wrote:
>> -                    "backend: %s \n", be->be_name, isglobal?"(global 
>> mode)":"");
>> +                    "backend: %s%s%s\n", be->be_name, isglobal?" 
>> ":"", isglobal?"(global mode)":"");
> Is there any reason that this section shouldn't just use 2 strings in 
> the format statement?  Something like this:
>
>     "backend: %s%s\n", be->be_name, isglobal?" (global mode)":"");
>
> Other than that minor nitpick, the changes look good.
Fixed that.  Thanks!

Pushed to master.
>
> -NGK

--
389-devel mailing list
389-devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/389-devel


[Index of Archives]     [Fedora Directory Announce]     [Fedora Users]     [Older Fedora Users Mail]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Review]     [Fedora Art]     [Fedora Music]     [Fedora Packaging]     [CentOS]     [Fedora SELinux]     [Big List of Linux Books]     [KDE Users]     [Fedora Art]     [Fedora Docs]

  Powered by Linux