The changes look good, but could you add Doxygen comment blocks for the new functions you added in slapi-plugin.h? -NGK On 06/08/2010 04:28 PM, Rich Megginson wrote: > These patches are to allow ds to use openldap with NSS and LDIF support > in Fedora rawhide (note that there are still some changes required to > enable NSS and LDIF support in rawhide). > 1) pass the NSS certdir as LDAP_OPT_X_TLS_CACERTDIR and other additions > to the TLS/SSL code > 2) use the openldap LDIF api - created a wrapper function around both > the mozldap and openldap code to make the rest of the server and plugin > code cleaner > 3) many of our scripts use ldapsearch and ldapmodify and simple bind - > when using the openldap versions of these tools, we have to pass -x to > use simple bind > 4) replace the missing proxy auth control functions > 5) fix some of our ldap client tools which used deprecated APIs > > http://rmeggins.fedorapeople.org/patches/0001-openldap-ldap_url_parse_ext-is-not-part-of-the-pub.patch > http://rmeggins.fedorapeople.org/patches/0002-fix-memleak-in-ldbm_config_read_instance_entries.patch > http://rmeggins.fedorapeople.org/patches/0003-Add-x-option-to-ldap-tools-when-using-openldap.patch > http://rmeggins.fedorapeople.org/patches/0004-openldap-add-support-for-missing-controls-add-ldi.patch > http://rmeggins.fedorapeople.org/patches/0005-port-client-tools-to-use-openldap-API.patch > http://rmeggins.fedorapeople.org/patches/0006-use-the-mozldap-versions-of-the-proxy-auth-control-c.patch > > -- > 389-devel mailing list > 389-devel@xxxxxxxxxxxxxxxxxxxxxxx > https://admin.fedoraproject.org/mailman/listinfo/389-devel > -- 389-devel mailing list 389-devel@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/389-devel