----- "Nathan Kinder" <nkinder@xxxxxxxxxx> wrote: > >> The admin server CGIs parse the start-slapd scripts to determine the > >> DS instance names. A recent format change to start-slapd caused this > >> parsing to break. These patches make the instance name easier to > >> parse from the script. One patch is for DS itself and one is for the > >> Admin Server. > >> > > ack - much better > > > Thanks, but I need to nak my own patch since it's imcomplete. > > This isn't going to work well when upgrading an instance. We don't > regenerate the start-slapd script when running 'setup-ds.pl -u'. This > means that an upgraded instance will not work properly with any of the > admin server CGIs that need to parse the instance name from > start-slapd. This issue is already a problem not related to this patch, > but it seems we should fix it along with this issue. > > I suppose the right thing to do is to make 'setup-ds.pl -u' generate a > new start-slapd script for the existing instances as well as a new > instance specific initconfig script if one doesn't exist. I think we > need to avoid wiping out an existing instance specific sysconfig script > since it may have been modified by an admin to add other stuff to it > (like KRB5_KTNAME for Kerberos). Do you see any problems with this > approach? Sorry that my changes caused this problem. Peace... :) Would it be better to have a pure configuration file (not script) in the instance directory that contains things like instance name, etc.? The start-dirsrv is a script, and parsing a script without a proper parser is risky. Same thing with the sysconfig scripts. Even a slight change in that file could break some regular expressions in the Perl modules. What do you think? Thanks. -- Endi S. Dewata -- 389-devel mailing list 389-devel@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/389-devel
