Nathan Kinder wrote: > New patch attached. Nice! mep.c:491 - value is not freed if it is not a valid filter - also would be nice to have the error message print value to show what the bogus filter is Do we plan on supporting binary attrs? e.g. mepstaticattr: blobattr:: base64value not sure if we care about this for the first iteration > > -NGK > > On 03/30/2010 01:24 PM, Nathan Kinder wrote: >> Please hold off on the review. I noticed one other thing that I need >> to address. A new patch will be sent out shortly. >> >> -NGK >> >> On 03/30/2010 01:18 PM, Nathan Kinder wrote: >>> >>> >>> -- >>> 389-devel mailing list >>> 389-devel@xxxxxxxxxxxxxxxxxxxxxxx >>> https://admin.fedoraproject.org/mailman/listinfo/389-devel >> >> >> -- >> 389-devel mailing list >> 389-devel@xxxxxxxxxxxxxxxxxxxxxxx >> https://admin.fedoraproject.org/mailman/listinfo/389-devel > > ------------------------------------------------------------------------ > > -- > 389-devel mailing list > 389-devel@xxxxxxxxxxxxxxxxxxxxxxx > https://admin.fedoraproject.org/mailman/listinfo/389-devel -- 389-devel mailing list 389-devel@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/389-devel