Re: [389-devel] Please Review: (514824) Multi-macro ACIs can cause double free if macro attribute does not exist

[Noriko Hosoi <nhosoi@xxxxxxxxxx>]

On 07/30/2009 05:10 PM, Nathan Kinder wrote:

On 07/30/2009 03:37 PM, Nathan Kinder wrote:

https://bugzilla.redhat.com/show_bug.cgi?id=514824

--
389-devel mailing list
389-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/fedora-directory-devel
  

Here's a new patch that addresses some issues Noriko brought up.

The list "a" was being set to NULL when we found an attribute match for a
macro, but this is no longer necessary now that we reset "a" to NULL when the
memory is handed off to the working_list (which covers both the cases of
finding/not finding the attribute).

We were also accessing element 0 of list "a" right after handing the memory off
to the working_list, but we weren't checking if "a" was NULL first.  I don't
believe that "a" could be NULL at this point, but it's safest to check first in
case there is some corner case we're not considering. 

-NGK

--
389-devel mailing list
389-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/fedora-directory-devel
  

Looks good.  Thanks for considering my questions!
--noriko

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature

--
389-devel mailing list
389-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/fedora-directory-devel