[389-devel] Please review: fix rpmlint issues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



There are a couple of rpmlint issues with 389-ds-base:
389-ds-base.x86_64: E: script-without-shebang /usr/lib64/dirsrv/perl/Resource.pm
...
389-ds-base.x86_64: E: executable-marked-as-config-file /etc/sysconfig/dirsrv

These are fixed by marking them as _DATA instead of _SCRIPTS in Makefile.am

I'm also changing the version to 1.2.1 to take into consideration the new syntax and paged results code.

Finally, this is the output of git diff, not git-format-patch, so you guys don't have to wade through all of those configure and Makefile.in diffs.

diff --git a/Makefile.am b/Makefile.am
index ffc27dd..6e6767e 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -260,7 +260,9 @@ bin_SCRIPTS = ldap/servers/slapd/tools/rsearch/scripts/dbgen.pl \
 	wrappers/repl-monitor \
 	ldap/admin/src/scripts/repl-monitor.pl
 
-perl_SCRIPTS = ldap/admin/src/scripts/SetupLog.pm \
+# SCRIPTS makes them executables - these are perl modules
+# and should not be marked as executable - so use DATA
+perl_DATA = ldap/admin/src/scripts/SetupLog.pm \
 	ldap/admin/src/scripts/Resource.pm \
 	ldap/admin/src/scripts/Util.pm \
 	ldap/admin/src/scripts/Setup.pm \
@@ -309,7 +311,7 @@ task_SCRIPTS = ldap/admin/src/scripts/template-bak2db \
 
 init_SCRIPTS = wrappers/$(PACKAGE_NAME)
 
-initconfig_SCRIPTS = ldap/admin/src/$(PACKAGE_NAME)
+initconfig_DATA = ldap/admin/src/$(PACKAGE_NAME)
 
 inf_DATA = ldap/admin/src/slapd.inf \
 	ldap/admin/src/scripts/dscreate.map \
diff --git a/configure.ac b/configure.ac
index d083484..056ef2a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2,7 +2,7 @@
 # Process this file with autoconf to produce a configure script.
 AC_PREREQ(2.59)
 # This version is the version returned by ns-slapd -v
-AC_INIT([dirsrv], [1.2.0], [http://bugzilla.redhat.com/])
+AC_INIT([dirsrv], [1.2.1], [http://bugzilla.redhat.com/])
 # AC_CONFIG_HEADER must be called right after AC_INIT.
 AC_CONFIG_HEADERS([config.h])
 AM_INIT_AUTOMAKE([1.9 foreign subdir-objects])

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature

--
Fedora-directory-devel mailing list
Fedora-directory-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/fedora-directory-devel

[Index of Archives]     [Fedora Directory Announce]     [Fedora Users]     [Older Fedora Users Mail]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Review]     [Fedora Art]     [Fedora Music]     [Fedora Packaging]     [CentOS]     [Fedora SELinux]     [Big List of Linux Books]     [KDE Users]     [Fedora Art]     [Fedora Docs]

  Powered by Linux