Re: [389-devel] Please review: [PATCH] Add Simple Paged Results

[Noriko Hosoi <nhosoi@xxxxxxxxxx>]

Rich Megginson wrote:
> Noriko Hosoi wrote:
> > The patch is located here (It's too big for email...):
> > http://nhosoi.fedorapeople.org/0001-Add-Simple-Paged-Results.patch
> In pagedresults.c there are several functions that get/set Connection* 
> internals - are these protected by conn->c_mutex?  Do they need to be?
A good point.  Updates are done by one thread, but the values could be 
read by other threads.  I'm going to add them and run some more tests.  
Thanks, Rich!
--noriko
> Otherwise, looks good.
> > I also updated the design doc on wiki:
> > http://directory.fedoraproject.org/wiki/Simple_Paged_Results_Design
> >
> > Comments on the doc would be appreciated, too.
> >
> > Thanks,
> > --noriko
> > ------------------------------------------------------------------------
> >
> > --
> > Fedora-directory-devel mailing list
> > Fedora-directory-devel@xxxxxxxxxx
> > https://www.redhat.com/mailman/listinfo/fedora-directory-devel
> >   
>
> ------------------------------------------------------------------------
>
> --
> Fedora-directory-devel mailing list
> Fedora-directory-devel@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/fedora-directory-devel
>

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature

--
Fedora-directory-devel mailing list
Fedora-directory-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/fedora-directory-devel