Looks good. Noriko Hosoi wrote:
Summary: LDAPI: referral mode needs LDAPI socket? https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230673This changes make LDAPI turned "off" if ldapifilepath is not set in the install inf file.Sorry, I should have done the discussion on bugzilla from the beginning. It's going to be a repeat, but for the record, if you could review the changes and comment on the bug, I'd appreciate it.--noriko nhosoi@xxxxxxxxxx changed: What |Removed |Added----------------------------------------------------------------------------devel_whiteboard| |review.comment#3? Record of the email discussion:------- Additional Comments From nhosoi@xxxxxxxxxx 2007-03-02 16:38 EST -------(In reply to comment #0)> Description of problem: > [error #2] > [...]> Also, to work around this problem, is it okay to add this code to create the> directory to put the ldapi unix socket if it does not exist?Richard Megginson wrote:I don't think we should create the directory if it does not exist. That doesn't seem right to me. I think we should just warn.Pete Rowley wrote:> You know, given our server installs with newinst.pl in regular cases and all this has > default config set up for directories we already write to, perhaps the right thing to do > is to have default off for ldapi. That would have minimum impact on tests that don't > care about it (and are set up other ways) and wouldn't effect server installs through> regular means.Richard Megginson wrote:Then ds_newinst could set it to "on" if the user specified an ldapifilepath. I think that would appease Andrew as well.Based upon the suggestions from Pete and Rich, if setting "ldapifilepath=/path/to/ldapifile/slapd-ID.socket" in the install inf file is used as a trigger to set ldapi to "on". Otherwise, set to "off". The function ds_gen_confs in create_instance.c switches between on and off depending upon the existence of ldapifilepath value. Also, the ldapi default setting in libglobs.c is changed to "off".------- Additional Comments From nhosoi@xxxxxxxxxx 2007-03-02 16:43 EST -------Created an attachment (id=149157)--> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=149157&action=view)cvs diffs (admin/src/create_instance.c, servers/slapd/libglobs.c) Changes:create_instance.c: if ldapifilepath is not passed, LDAPI is disabled in thenewly created instance.libglobs.c: LDAPI is disabled in the initial configuration parameter setting.------------------------------------------------------------------------ -- Fedora-directory-devel mailing list Fedora-directory-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-directory-devel
-- Pete
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature
-- Fedora-directory-devel mailing list Fedora-directory-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-directory-devel
