[Fedora-directory-devel] Please review: [Bug 206724] Replacing PR_SetNetAddr with PRLDAP_SET_PORT for IPv6 support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Summary: Replacing PR_SetNetAddr with PRLDAP_SET_PORT for IPv6 support

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206724

Description of problem:
PR_SetNetAddr was used just to set port into PRNetAddr.  The function has a side
effect, which accidentally cleans up the scope_id field.  So, if the purpose of
calling PR_SetNetAddr is to set port, we were suggested to introduce a macro to
achieve the goal.

Fix proposal:
Created an attachment (id=136399)
--> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=136399&action=view)
cvs diff slapi-private.h connection.c daemon.c

Files:
 slapi-private.h
 connection.c
 daemon.c

Changes:
slapi-private.h: introduced PRLDAP_SET_PORT to set port to the port field in
PRNetAddr.  A copy of the same macro in LDAP C SDK (v6).  Note: once NSPR
provides an equivalent API, we may want to replace this macro with the one. (the NSPR compatibility issue remains, though.)
connection.c, daemon.c: replaced PR_SetNetAddr with PRLDAP_SET_PORT.

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature


[Index of Archives]     [Fedora Directory Announce]     [Fedora Users]     [Older Fedora Users Mail]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Review]     [Fedora Art]     [Fedora Music]     [Fedora Packaging]     [CentOS]     [Fedora SELinux]     [Big List of Linux Books]     [KDE Users]     [Fedora Art]     [Fedora Docs]

  Powered by Linux