Re: [Fedora-directory-devel] Please Review: (204355) Winsync code should be removed from ldapserver tree

[Rob Crittenden <rcritten@xxxxxxxxxx>]

Nathan Kinder wrote:
> Rob Crittenden wrote:
>
> > Nathan Kinder wrote:
> >
> > > https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204355
> > > Bug(s) fixed: 204355
> > > Bug Description: The Windows Sync code (for both ntds.msi and 
> > > passsync.msi) should
> > >    be removed from the ldapserver top-level directory in the source 
> > > tree.  This
> > >    code was moved to it's own top-level winsync directory some time ago.
> > > Reviewed by: ???
> > > Files: See diffs
> > > Branch: HEAD
> > > Fix Description: We can safely remove the ldapserver/ldap/synctools and
> > >    ldapserver/ldap/servers/ntds directories from the ldapserver 
> > > tree.  Some
> > >    Makefile changes are also necessary to not build these pieces and 
> > > to not
> > >    pull some of the components needed to build them.
> > > Platforms tested: RHEL4
> > > Flag Day: no
> > > Doc impact: no
> > > https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=135064
> >
> >
> > Where does BUILD_NTDS get set? Is that needed anywhere else?
>
> That's a build option that is supplied on the command-line when invoking 
> make.  It's not needed for anything else.
>
> -NGK

Ok, it looks fine then.

rob

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature