[Bug 1139041] Review Request: perl-Devel-Timer - Track and report execution time for parts of code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1139041



--- Comment #1 from Petr Šabata <psabata@xxxxxxxxxx> ---
So, for the build time deps...  Your Makefile.PL uses the bundled
inc::Module::Install.  That means you need to list the dependencies of the
bundled distribution, too.  In your case that means the following:
- Config, inc/Module/Install/Can.pm:5
- Cwd, inc/Module/Install.pm:22
- Fcntl, inc/Module/Install/Makefile.pm:7
- File::Find, inc/Module/Install.pm:23
- inc/Module/Install.pm:24
- ExtUtils::MM_Unix, inc/Module/Install/Metadata.pm:323,
inc/Module/Install/Metadata.pm:332

Other missing build time dep, used by the testsuite:
- lib, t/my-timer.t:8

You also list a dependency on Carp which is not used or even mentioned anywhere
in the tarball.  Please, remove it.

Nitpick: Perhaps you could change the el5 check in the %install section to be
the same as the check around the BuildRoot tag?  Or the other way around.  Just
to be consistent.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6EQRtdziag&a=cc_unsubscribe
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/perl-devel





[Index of Archives]     [Fedora Announce]     [Fedora Kernel]     [Fedora Testing]     [Fedora Legacy Announce]     [Fedora PHP Devel]     [Kernel Devel]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Big List of Linux Books]     [Gimp]     [Yosemite Information]
  Powered by Linux