commit b79c51ab382f441ec6b33c06c79916c69bf3bde1
Author: Paul Howarth <paul@xxxxxxxxxxxx>
Date: Fri Oct 3 18:47:50 2014 +0100
Run the optional tests too
- Classify buildreqs by usage
- Don't use macros for commands
- Don't need to remove empty directories from the buildroot
- Use DESTDIR rather than PERL_INSTALL_ROOT
- Make %files list more explicit
perl-Variable-Magic.spec | 61 ++++++++++++++++++++++++++++++++-------------
1 files changed, 43 insertions(+), 18 deletions(-)
---
diff --git a/perl-Variable-Magic.spec b/perl-Variable-Magic.spec
index effe557..72d8339 100644
--- a/perl-Variable-Magic.spec
+++ b/perl-Variable-Magic.spec
@@ -1,27 +1,48 @@
Name: perl-Variable-Magic
Version: 0.54
-Release: 1%{?dist}
+Release: 2%{?dist}
Summary: Associate user-defined magic to variables from Perl
License: GPL+ or Artistic
Group: Development/Libraries
URL: http://search.cpan.org/dist/Variable-Magic/
Source0: http://search.cpan.org/CPAN/authors/id/V/VP/VPIT/Variable-Magic-%{version}.tar.gz
+# Module Build
+BuildRequires: perl
BuildRequires: perl(Config)
BuildRequires: perl(ExtUtils::MakeMaker)
+# Module Runtime
+BuildRequires: perl(base)
+BuildRequires: perl(Carp)
+BuildRequires: perl(Exporter)
+BuildRequires: perl(strict)
+BuildRequires: perl(warnings)
+BuildRequires: perl(XSLoader)
+# Test Suite
+BuildRequires: perl(B::Deparse)
+BuildRequires: perl(bytes)
+BuildRequires: perl(lib)
BuildRequires: perl(Test::More)
-BuildRequires: perl(Test::Pod) >= 1.14
-BuildRequires: perl(Test::Pod::Coverage) >= 1.04
-BuildRequires: perl(Test::Portability::Files)
-%if ! 0%{?rhel} >= 7
-BuildRequires: perl(Test::Kwalitee)
-%endif
-Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
+BuildRequires: perl(vars)
+# Optional Tests
+BuildRequires: perl(Capture::Tiny) >= 0.08
+BuildRequires: perl(Hash::Util::FieldHash)
+BuildRequires: perl(Perl::Destruct::Level)
+BuildRequires: perl(Symbol)
+BuildRequires: perl(threads)
+BuildRequires: perl(threads::shared)
+BuildRequires: perl(Tie::Array)
+BuildRequires: perl(Tie::Hash)
+# Runtime
+Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
+Requires: perl(Carp)
+Requires: perl(Exporter)
+Requires: perl(XSLoader)
%{?perl_default_filter}
%description
Magic is Perl way of enhancing objects. This mechanism let the user add
-extra data to any variable and hook syntaxical operations (such as access,
+extra data to any variable and hook syntactical operations (such as access,
assignation or destruction) that can be applied to it. With this module,
you can add your own magic to any variable without the pain of the C API.
@@ -29,28 +50,32 @@ you can add your own magic to any variable without the pain of the C API.
%setup -q -n Variable-Magic-%{version}
%build
-%{__perl} Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS"
+perl Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS"
make %{?_smp_mflags}
%install
-make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
-
+make pure_install DESTDIR=$RPM_BUILD_ROOT
find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \;
find $RPM_BUILD_ROOT -type f -name '*.bs' -size 0 -exec rm -f {} \;
-find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;
-
-%{_fixperms} $RPM_BUILD_ROOT/*
+%{_fixperms} $RPM_BUILD_ROOT
%check
make test
%files
%doc Changes README
-%{perl_vendorarch}/auto/*
-%{perl_vendorarch}/Variable*
-%{_mandir}/man3/*
+%{perl_vendorarch}/auto/Variable/
+%{perl_vendorarch}/Variable/
+%{_mandir}/man3/Variable::Magic.3*
%changelog
+* Fri Oct 3 2014 Paul Howarth <paul@xxxxxxxxxxxx> - 0.54-2
+- Classify buildreqs by usage
+- Don't use macros for commands
+- Don't need to remove empty directories from the buildroot
+- Use DESTDIR rather than PERL_INSTALL_ROOT
+- Make %%files list more explicit
+
* Sat Sep 27 2014 Emmanuel Seyman <emmanuel@xxxxxxxxx> - 0.54-1
- Update to 0.54
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/perl-devel
