Re: [perl-Email-Abstract/epel7] Do not BR packages that are not present in el7

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/07/2014 03:03 PM, Lubomir Rintel wrote:
commit 6154c8d5bf3654510f44dce7f86edc87113acab5
Author: Lubomir Rintel <lkundrak@xxxxx>
Date:   Fri Mar 7 15:02:58 2014 +0100

     Do not BR packages that are not present in el7

  perl-Email-Abstract.spec |   10 ++++++++--
  1 files changed, 8 insertions(+), 2 deletions(-)
---
diff --git a/perl-Email-Abstract.spec b/perl-Email-Abstract.spec
index ee6f5cd..ad6336d 100644
--- a/perl-Email-Abstract.spec
+++ b/perl-Email-Abstract.spec
@@ -1,6 +1,6 @@
  Name:           perl-Email-Abstract
  Version:        3.007
-Release:        1%{?dist}
+Release:        1%{?dist}.1
  Summary:        Unified interface to mail representations
  Group:          Development/Libraries
  License:        GPL+ or Artistic
@@ -17,8 +17,11 @@ BuildRequires:  perl(Test::More) >= 0.96
  BuildRequires:  perl(lib)
  BuildRequires:  perl(strict)
  BuildRequires:  perl(warnings)
-BuildRequires:  perl(Mail::Message), perl(Scalar::Util)
+BuildRequires:  perl(Scalar::Util)
+%if 0%{?rhel} == 0
+BuildRequires:  perl(Mail::Message)
  BuildRequires:  perl(Email::MIME)
+%endif

Are you sure this step is helpful?

These requirements also are run-time requirements, which means all you are doing is to remove BR: which expose runtime-requirements,
but actually are shipping a crippled package.

IMO, the correct fix would be to add the missing perl-modules to rhel and not to remove these BRs.

Ralf

--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/perl-devel





[Index of Archives]     [Fedora Announce]     [Fedora Kernel]     [Fedora Testing]     [Fedora Legacy Announce]     [Fedora PHP Devel]     [Kernel Devel]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Big List of Linux Books]     [Gimp]     [Yosemite Information]
  Powered by Linux