commit 8cc75202b9138ae91d69ffff170a46f3ba1e98e9
Author: Paul Howarth <paul@xxxxxxxxxxxx>
Date: Thu Feb 13 10:16:03 2014 +0000
Spec tidy-up
- Fix some typos in the %changelog
- Specify more build dependencies
- Don't need to remove empty directories from the buildroot
- Don't use macros for commands
- Use %{_fixperms} macro rather than our own chmod incantation
- Use DESTDIR rather than PERL_INSTALL_ROOT
- Drop %defattr, redundant since rpm 4.4
- Make %files list more explicit
perl-GDGraph3d.spec | 41 ++++++++++++++++++++++++++++-------------
1 files changed, 28 insertions(+), 13 deletions(-)
---
diff --git a/perl-GDGraph3d.spec b/perl-GDGraph3d.spec
index cc14f61..ca908f8 100644
--- a/perl-GDGraph3d.spec
+++ b/perl-GDGraph3d.spec
@@ -1,20 +1,28 @@
Name: perl-GDGraph3d
Version: 0.63
-Release: 22%{?dist}
+Release: 23%{?dist}
Summary: 3D graph generation package for Perl
Group: Development/Libraries
License: GPL+ or Artistic
URL: http://search.cpan.org/dist/GD-Graph3d/
Source0: http://www.cpan.org/authors/id/W/WA/WADG/GD-Graph3d-%{version}.tar.gz
-BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
+BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(id -nu)
BuildArch: noarch
-BuildRequires: perl(GD), perl(GD::Text), perl(GD::Graph)
+BuildArch: noarch
+BuildRequires: perl(base)
+BuildRequires: perl(constant)
+BuildRequires: perl(Data::Dumper)
BuildRequires: perl(ExtUtils::MakeMaker)
-Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
+BuildRequires: perl(GD)
+BuildRequires: perl(GD::Text)
+BuildRequires: perl(GD::Graph)
+BuildRequires: perl(strict)
+Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
Provides: perl-GD-Graph3d = %{version}-%{release}
+
%description
This is the GD::Graph3d extensions module. It provides 3D graphs for
the GD::Graph module by Martien Verbruggen, which in turn generates
@@ -23,20 +31,19 @@ graph using Lincoln Stein's GD.pm.
%prep
%setup -q -n GD-Graph3d-%{version}
-%{__perl} -pi -e 's/\r//g' Changes
+perl -pi -e 's/\r//g' Changes
%build
-%{__perl} Makefile.PL INSTALLDIRS=vendor
+perl Makefile.PL INSTALLDIRS=vendor
make %{?_smp_mflags}
%install
rm -rf $RPM_BUILD_ROOT
-make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
+make pure_install DESTDIR=$RPM_BUILD_ROOT
find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} ';'
-find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null ';'
-chmod -R u+w $RPM_BUILD_ROOT/*
+%{_fixperms} $RPM_BUILD_ROOT
%check
@@ -48,13 +55,21 @@ rm -rf $RPM_BUILD_ROOT
%files
-%defattr(-,root,root,-)
%doc Changes
%{perl_vendorlib}/GD/
-%{_mandir}/man3/*.3pm*
+%{_mandir}/man3/GD::Graph3d.3pm*
%changelog
+* Thu Feb 13 2014 Paul Howarth <paul@xxxxxxxxxxxx> - 0.63-23
+- Specify more build dependencies
+- Don't need to remove empty directories from the buildroot
+- Don't use macros for commands
+- Use %%{_fixperms} macro rather than our own chmod incantation
+- Use DESTDIR rather than PERL_INSTALL_ROOT
+- Drop %%defattr, redundant since rpm 4.4
+- Make %%files list more explicit
+
* Sat Aug 03 2013 Fedora Release Engineering <rel-eng@xxxxxxxxxxxxxxxxxxxxxxx> - 0.63-22
- Rebuilt for https://fedoraproject.org/wiki/Fedora_20_Mass_Rebuild
@@ -80,7 +95,7 @@ rm -rf $RPM_BUILD_ROOT
- Rebuilt for https://fedoraproject.org/wiki/Fedora_15_Mass_Rebuild
* Thu Dec 16 2010 Marcela Maslanova <mmaslano@xxxxxxxxxx> - 0.63-14
-- 661697 rebuild for fixing problems with vendorach/lib
+- Rebuild to fix problems with vendorarch/lib (#661697)
* Sun May 02 2010 Marcela Maslanova <mmaslano@xxxxxxxxxx> - 0.63-13
- Mass rebuild with perl-5.12.0
@@ -116,7 +131,7 @@ rm -rf $RPM_BUILD_ROOT
* Thu Dec 22 2005 Jose Pedro Oliveira <jpo at di.uminho.pt> - 0.63-4
- Dist tag.
-* Fri Apr 7 2005 Michael Schwendt <mschwendt[AT]users.sf.net> - 0.63-3
+* Wed Apr 6 2005 Michael Schwendt <mschwendt[AT]users.sf.net> - 0.63-3
- rebuilt
* Sat Jan 15 2005 Jose Pedro Oliveira <jpo at di.uminho.pt> - 0:0.63-2
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/perl-devel
