commit 4c81294b0873d33c655563883bd14d267e7e15cf Author: Petr Písař <ppisar@xxxxxxxxxx> Date: Thu Nov 28 13:29:48 2013 +0100 0.039 bump .gitignore | 1 + ...-not-use-already-existing-temporary-files.patch | 45 -------------------- ...y-0.039-Croak-on-failed-write-into-a-file.patch | 14 +++--- perl-HTTP-Tiny.spec | 14 +++--- sources | 2 +- 5 files changed, 16 insertions(+), 60 deletions(-) --- diff --git a/.gitignore b/.gitignore index 2aa9a85..5808a1b 100644 --- a/.gitignore +++ b/.gitignore @@ -9,3 +9,4 @@ /HTTP-Tiny-0.036.tar.gz /HTTP-Tiny-0.037.tar.gz /HTTP-Tiny-0.038.tar.gz +/HTTP-Tiny-0.039.tar.gz diff --git a/HTTP-Tiny-0.038-Croak-on-failed-write-into-a-file.patch b/HTTP-Tiny-0.039-Croak-on-failed-write-into-a-file.patch similarity index 66% rename from HTTP-Tiny-0.038-Croak-on-failed-write-into-a-file.patch rename to HTTP-Tiny-0.039-Croak-on-failed-write-into-a-file.patch index 3c7d069..ec98fcb 100644 --- a/HTTP-Tiny-0.038-Croak-on-failed-write-into-a-file.patch +++ b/HTTP-Tiny-0.039-Croak-on-failed-write-into-a-file.patch @@ -1,7 +1,7 @@ -From 4ead7785b495b48f027f77abe2b1173f3c05f02c Mon Sep 17 00:00:00 2001 +From 2dba24236cf734ce89a058541815eef2eb59475c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@xxxxxxxxxx> Date: Wed, 27 Nov 2013 10:45:39 +0100 -Subject: [PATCH 1/2] Croak on failed write into a file +Subject: [PATCH] Croak on failed write into a file MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit @@ -16,12 +16,12 @@ Signed-off-by: Petr Písař <ppisar@xxxxxxxxxx> 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/HTTP/Tiny.pm b/lib/HTTP/Tiny.pm -index 0178d65..48763ff 100644 +index bb824c2..9d98e1f 100644 --- a/lib/HTTP/Tiny.pm +++ b/lib/HTTP/Tiny.pm -@@ -116,7 +116,10 @@ sub mirror { - open my $fh, ">", $tempfile - or Carp::croak(qq/Error: Could not open temporary file $tempfile for downloading: $!\n/); +@@ -118,7 +118,10 @@ sub mirror { + sysopen my $fh, $tempfile, Fcntl::O_CREAT()|Fcntl::O_EXCL()|Fcntl::O_WRONLY() + or Carp::croak(qq/Error: Could not create temporary file $tempfile for downloading: $!\n/); binmode $fh; - $args->{data_callback} = sub { print {$fh} $_[0] }; + $args->{data_callback} = sub { @@ -30,7 +30,7 @@ index 0178d65..48763ff 100644 + }; my $response = $self->request('GET', $url, $args); close $fh - or Carp::croak(qq/Error: Could not close temporary file $tempfile: $!\n/); + or Carp::croak(qq/Error: Caught error closing temporary file $tempfile: $!\n/); -- 1.8.3.1 diff --git a/perl-HTTP-Tiny.spec b/perl-HTTP-Tiny.spec index 881443a..c5739c4 100644 --- a/perl-HTTP-Tiny.spec +++ b/perl-HTTP-Tiny.spec @@ -1,6 +1,6 @@ Name: perl-HTTP-Tiny -Version: 0.038 -Release: 2%{?dist} +Version: 0.039 +Release: 1%{?dist} Summary: Small, simple, correct HTTP/1.1 client License: GPL+ or Artistic Group: Development/Libraries @@ -8,10 +8,7 @@ URL: http://search.cpan.org/dist/HTTP-Tiny/ Source0: http://www.cpan.org/authors/id/D/DA/DAGOLDEN/HTTP-Tiny-%{version}.tar.gz # Check for write failure, bug #1031096, # <https://github.com/chansen/p5-http-tiny/issues/32> -Patch0: HTTP-Tiny-0.038-Croak-on-failed-write-into-a-file.patch -# Do not use already existing temporary files, bug #1031096, -# <https://github.com/chansen/p5-http-tiny/issues/32> -Patch1: HTTP-Tiny-0.038-Do-not-use-already-existing-temporary-files.patch +Patch0: HTTP-Tiny-0.039-Croak-on-failed-write-into-a-file.patch BuildArch: noarch BuildRequires: perl BuildRequires: perl(ExtUtils::MakeMaker) >= 6.17 @@ -45,6 +42,7 @@ BuildRequires: perl(IO::Socket::INET) BuildRequires: perl(IPC::Cmd) Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version)) Requires: perl(bytes) +Requires: perl(Fcntl) Requires: perl(MIME::Base64) Requires: perl(Time::Local) @@ -59,7 +57,6 @@ resumes after EINTR. %prep %setup -q -n HTTP-Tiny-%{version} %patch0 -p1 -%patch1 -p1 %build perl Makefile.PL INSTALLDIRS=vendor @@ -79,6 +76,9 @@ make test %{_mandir}/man3/* %changelog +* Thu Nov 28 2013 Petr Pisar <ppisar@xxxxxxxxxx> - 0.039-1 +- 0.039 bump + * Wed Nov 27 2013 Petr Pisar <ppisar@xxxxxxxxxx> - 0.038-2 - Croak on failed write into a file (bug #1031096) - Do not use already existing temporary files (bug #1031096) diff --git a/sources b/sources index ae5b36c..0bf3f73 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -55f73a9b1cc9843e307487d2d7fe637a HTTP-Tiny-0.038.tar.gz +322bcc9567cc2c8d6202e0cb4a9528cc HTTP-Tiny-0.039.tar.gz -- Fedora Extras Perl SIG http://www.fedoraproject.org/wiki/Extras/SIGs/Perl perl-devel mailing list perl-devel@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/perl-devel