commit acc467f9e0e573d7d84ed083b4b3299b262fae77
Author: Paul Howarth <paul@xxxxxxxxxxxx>
Date: Tue Feb 26 14:09:01 2013 +0000
Clean up and fix FTBFS (#914250)
- Add patch to fix broken POD in README, causing FTBFS (#914250)
- BR:/R: perl(Carp)
- BR: /usr/bin/pod2text, perl(base), perl(Class::Accessor::Fast) and
perl(ExtUtils::MakeMaker)
- Upstream doesn't ship license files so neither should we
- Enhance %description
- Don't use macros for commands
- Don't need to remove empty directories from the buildroot
- Use %{_fixperms} macro rather than our own chmod incantation
- Use DESTDIR rather than PERL_INSTALL_ROOT
- Make %files list more explicit
.gitignore | 2 +-
Class-Accessor-Chained-0.01-pod.patch | 10 +++++
perl-Class-Accessor-Chained.spec | 59 ++++++++++++++++++++++++---------
3 files changed, 54 insertions(+), 17 deletions(-)
---
diff --git a/.gitignore b/.gitignore
index 1958147..8d48b4e 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1 +1 @@
-Class-Accessor-Chained-0.01.tar.gz
+/Class-Accessor-Chained-[0-9.]*.tar.gz
diff --git a/Class-Accessor-Chained-0.01-pod.patch b/Class-Accessor-Chained-0.01-pod.patch
new file mode 100644
index 0000000..354d68c
--- /dev/null
+++ b/Class-Accessor-Chained-0.01-pod.patch
@@ -0,0 +1,10 @@
+--- README
++++ README
+@@ -38,6 +38,7 @@
+ =item 0.01 Monday 24th November, 2003
+
+ initial CPAN release
++
+ =back
+
+ =head1 AUTHOR
diff --git a/perl-Class-Accessor-Chained.spec b/perl-Class-Accessor-Chained.spec
index 476f0ae..621e0a6 100644
--- a/perl-Class-Accessor-Chained.spec
+++ b/perl-Class-Accessor-Chained.spec
@@ -1,45 +1,72 @@
Name: perl-Class-Accessor-Chained
Version: 0.01
-Release: 19%{?dist}
+Release: 20%{?dist}
Summary: Make chained accessors
Group: Development/Libraries
License: GPL+ or Artistic
URL: http://search.cpan.org/dist/Class-Accessor-Chained/
Source0: http://search.cpan.org/CPAN/authors/id/R/RC/RCLAMP/Class-Accessor-Chained-%{version}.tar.gz
+Patch0: Class-Accessor-Chained-0.01-pod.patch
BuildArch: noarch
-BuildRequires: perl(Class::Accessor), perl(Test::More)
-BuildRequires: perl(Pod::Perldoc)
-Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
-Requires: perl(Class::Accessor), perl(Class::Accessor::Fast)
+BuildRequires: /usr/bin/pod2text
+BuildRequires: perl(base)
+BuildRequires: perl(Carp)
+BuildRequires: perl(Class::Accessor)
+BuildRequires: perl(Class::Accessor::Fast)
+BuildRequires: perl(ExtUtils::MakeMaker)
+BuildRequires: perl(Test::More)
+Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
+Requires: perl(Carp)
+Requires: perl(Class::Accessor)
+Requires: perl(Class::Accessor::Fast)
%description
-%{summary}.
+A chained accessor is one that always returns the object when called with
+parameters (to set), and the value of the field when called with no arguments.
+This module subclasses Class::Accessor in order to provide the same
+mk_accessors interface.
%prep
%setup -q -n Class-Accessor-Chained-%{version}
+
+# Fix broken POD in README (#914250)
+%patch0
+
+# Convert POD-formatted README to plain text for %%doc
pod2text README > README.txt
-perldoc -t perlartistic > Artistic
-perldoc -t perlgpl > COPYING
%build
-%{__perl} Makefile.PL INSTALLDIRS=vendor
+perl Makefile.PL INSTALLDIRS=vendor
make %{?_smp_mflags}
%install
-make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
+make pure_install DESTDIR=$RPM_BUILD_ROOT
find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} ';'
-find $RPM_BUILD_ROOT -type d -depth -exec rmdir {} 2>/dev/null ';'
-chmod -R u+w $RPM_BUILD_ROOT/*
+%{_fixperms} $RPM_BUILD_ROOT
%check
make test
%files
-%doc Changes README.txt Artistic COPYING
-%{perl_vendorlib}/Class/Accessor
-%{_mandir}/man3/*.3*
+%doc Changes README.txt
+%{perl_vendorlib}/Class/Accessor/
+%{_mandir}/man3/Class::Accessor::Chained.3pm*
+%{_mandir}/man3/Class::Accessor::Chained::Fast.3pm*
%changelog
+* Tue Feb 26 2013 Paul Howarth <paul@xxxxxxxxxxxx> - 0.01-20
+- Add patch to fix broken POD in README, causing FTBFS (#914250)
+- BR:/R: perl(Carp)
+- BR: /usr/bin/pod2text, perl(base), perl(Class::Accessor::Fast) and
+ perl(ExtUtils::MakeMaker)
+- Upstream doesn't ship license files so neither should we
+- Enhance %%description
+- Don't use macros for commands
+- Don't need to remove empty directories from the buildroot
+- Use %%{_fixperms} macro rather than our own chmod incantation
+- Use DESTDIR rather than PERL_INSTALL_ROOT
+- Make %%files list more explicit
+
* Thu Feb 14 2013 Fedora Release Engineering <rel-eng@xxxxxxxxxxxxxxxxxxxxxxx> - 0.01-19
- Rebuilt for https://fedoraproject.org/wiki/Fedora_19_Mass_Rebuild
@@ -62,7 +89,7 @@ make test
- Rebuilt for https://fedoraproject.org/wiki/Fedora_15_Mass_Rebuild
* Wed Dec 15 2010 Marcela Maslanova <mmaslano@xxxxxxxxxx> - 0.01-12
-- 661697 rebuild for fixing problems with vendorach/lib
+- Rebuild to fix problems with vendorarch/lib (#661697)
* Fri Apr 30 2010 Marcela Maslanova <mmaslano@xxxxxxxxxx> - 0.01-11
- Mass rebuild with perl-5.12.0
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/perl-devel
