commit 6dadbc134140aa0fdb707e6d6ead14dc5d6929aa
Author: Paul Howarth <paul@xxxxxxxxxxxx>
Date: Tue Apr 10 21:40:19 2012 +0100
Spec clean-up
- Don't generate license files; that's upstream's job
- Drop perl(Pod::Perldoc) buildreq, no longer needed
- One buildreq per line for readability
- BR: perl(base), perl(DBI) and perl(ExtUtils::MakeMaker)
- Don't need to remove empty directories from buildroot
- Don't use macros for commands
- Improve %description
- Use %{_fixperms} macro rather than our own chmod incantation
- Use DESTDIR rather than PERL_INSTALL_ROOT
- Own directory %{perl_vendorlib}/Class/
- Make %files list more explicit
- Package the README file
.gitignore | 2 +-
perl-Class-DBI-Plugin.spec | 65 ++++++++++++++++++++++++++++++++-----------
2 files changed, 49 insertions(+), 18 deletions(-)
---
diff --git a/.gitignore b/.gitignore
index b5ce02f..c91c749 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1 +1 @@
-Class-DBI-Plugin-0.03.tar.gz
+/Class-DBI-Plugin-0.03.tar.gz
diff --git a/perl-Class-DBI-Plugin.spec b/perl-Class-DBI-Plugin.spec
index 6121916..4a9a250 100644
--- a/perl-Class-DBI-Plugin.spec
+++ b/perl-Class-DBI-Plugin.spec
@@ -1,47 +1,78 @@
Name: perl-Class-DBI-Plugin
Version: 0.03
-Release: 17%{?dist}
+Release: 18%{?dist}
Summary: Abstract base class for Class::DBI plugins
Group: Development/Libraries
License: GPL+ or Artistic
URL: http://search.cpan.org/dist/Class-DBI-Plugin
Source0: http://search.cpan.org/CPAN/authors/id/J/JC/JCZEUS/Class-DBI-Plugin-%{version}.tar.gz
BuildArch: noarch
-BuildRequires: perl(Class::DBI), perl(DBD::SQLite), perl(SQL::Abstract)
+# Install
+BuildRequires: perl(ExtUtils::MakeMaker)
+# Module
+BuildRequires: perl(Class::DBI) >= 0.9
+# Test
+BuildRequires: perl(base)
+BuildRequires: perl(DBD::SQLite)
+BuildRequires: perl(DBI)
+BuildRequires: perl(SQL::Abstract)
BuildRequires: perl(Test::More)
-BuildRequires: perl(Pod::Perldoc)
-Requires: perl(Class::DBI)
-Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
+Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
+Requires: perl(Class::DBI)
%description
-%{summary}.
+Class::DBI::Plugin is an abstract base class for Class::DBI plugins. Its
+purpose is to make writing plugins easier. Writers of plugins should be able
+to concentrate on the functionality their module provides, instead of having
+to deal with the symbol table hackery involved when writing a plugin module.
+Only three things must be remembered:
+
+* All methods to be exported are given the "Plugged" attribute. All other
+ methods are not exported to the plugged-in class.
+
+* Method calls that are to be sent to the plugged-in class are put in the
+ init() method. Examples of these are set_sql(), add_trigger() and so on.
+
+* The class parameter for the init() method and the "Plugged" methods is the
+ plugged-in class, not the plugin class.
%prep
%setup -q -n Class-DBI-Plugin-%{version}
-perldoc -t perlartistic > Artistic
-perldoc -t perlgpl > COPYING
%build
-%{__perl} Makefile.PL INSTALLDIRS=vendor
+perl Makefile.PL INSTALLDIRS=vendor
make %{?_smp_flags}
%install
-make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
+make pure_install DESTDIR=$RPM_BUILD_ROOT
find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} ';'
-find $RPM_BUILD_ROOT -type d -depth -exec rmdir {} 2>/dev/null ';'
-chmod -R u+w $RPM_BUILD_ROOT/*
+%{_fixperms} $RPM_BUILD_ROOT
%check
make test
%files
-%doc Changes COPYING Artistic
-%{perl_vendorlib}/Class/DBI
-%{_mandir}/man3/*.3*
+%doc Changes README
+%{perl_vendorlib}/Class/
+%{_mandir}/man3/Class::DBI::Plugin.3pm*
%changelog
+* Tue Apr 10 2012 Paul Howarth <paul@xxxxxxxxxxxx> - 0.03-18
+- Don't generate license files; that's upstream's job
+- Drop perl(Pod::Perldoc) buildreq, no longer needed
+- One buildreq per line for readability
+- BR: perl(base), perl(DBI) and perl(ExtUtils::MakeMaker)
+- Don't need to remove empty directories from buildroot
+- Don't use macros for commands
+- Improve %%description
+- Use %%{_fixperms} macro rather than our own chmod incantation
+- Use DESTDIR rather than PERL_INSTALL_ROOT
+- Own directory %%{perl_vendorlib}/Class/
+- Make %%files list more explicit
+- Package the README file
+
* Mon Jan 23 2012 Tom Callaway <spot@xxxxxxxxxxxxxxxxx> - 0.03-17
-- fix build
+- Fix build
* Fri Jan 13 2012 Fedora Release Engineering <rel-eng@xxxxxxxxxxxxxxxxxxxxxxx> - 0.03-16
- Rebuilt for https://fedoraproject.org/wiki/Fedora_17_Mass_Rebuild
@@ -56,7 +87,7 @@ make test
- Rebuilt for https://fedoraproject.org/wiki/Fedora_15_Mass_Rebuild
* Wed Dec 15 2010 Marcela Maslanova <mmaslano@xxxxxxxxxx> - 0.03-12
-- 661697 rebuild for fixing problems with vendorach/lib
+- Rebuild to fix problems with vendorarch/lib (#661697)
* Fri Apr 30 2010 Marcela Maslanova <mmaslano@xxxxxxxxxx> - 0.03-11
- Mass rebuild with perl-5.12.0
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/perl-devel
