commit 9c97ff7e83379604d23898e66bfdd6f3d9751beb
Author: Paul Howarth <paul@xxxxxxxxxxxx>
Date: Mon Mar 26 14:13:57 2012 +0100
Spec clean-up
- BR: perl(base), perl(Exporter), perl(Scalar::Util), perl(Tie::RefHash) ≥ 1.34
- Don't use macros for commands
- Drop %defattr, redundant since rpm 4.4
- Make %files list more explicit
- Don't need to remove empty directories from buildroot
- Use DESTDIR rather than PERL_INSTALL_ROOT
- Use tabs
.gitignore | 2 +-
perl-Tie-RefHash-Weak.spec | 72 ++++++++++++++++++++++++-------------------
2 files changed, 41 insertions(+), 33 deletions(-)
---
diff --git a/.gitignore b/.gitignore
index 8dae941..4a947a2 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1 +1 @@
-Tie-RefHash-Weak-0.09.tar.gz
+/Tie-RefHash-Weak-[0-9.]*.tar.gz
diff --git a/perl-Tie-RefHash-Weak.spec b/perl-Tie-RefHash-Weak.spec
index 5f66afe..5e673e2 100644
--- a/perl-Tie-RefHash-Weak.spec
+++ b/perl-Tie-RefHash-Weak.spec
@@ -1,18 +1,22 @@
-Name: perl-Tie-RefHash-Weak
-Version: 0.09
-Release: 9%{?dist}
-Summary: Tie::RefHash subclass with weakened references in the keys
-License: GPL+ or Artistic
-Group: Development/Libraries
-URL: http://search.cpan.org/dist/Tie-RefHash-Weak/
-Source0: http://www.cpan.org/authors/id/N/NU/NUFFIN/Tie-RefHash-Weak-%{version}.tar.gz
-BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
-BuildArch: noarch
-BuildRequires: perl(ExtUtils::MakeMaker)
-BuildRequires: perl(Task::Weaken)
-BuildRequires: perl(Variable::Magic)
-BuildRequires: perl(Test::More)
-Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
+Name: perl-Tie-RefHash-Weak
+Version: 0.09
+Release: 10%{?dist}
+Summary: Tie::RefHash subclass with weakened references in the keys
+License: GPL+ or Artistic
+Group: Development/Libraries
+URL: http://search.cpan.org/dist/Tie-RefHash-Weak/
+Source0: http://search.cpan.org/CPAN/authors/id/N/NU/NUFFIN/Tie-RefHash-Weak-%{version}.tar.gz
+BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(id -nu)
+BuildArch: noarch
+BuildRequires: perl(base)
+BuildRequires: perl(Exporter)
+BuildRequires: perl(ExtUtils::MakeMaker)
+BuildRequires: perl(Scalar::Util)
+BuildRequires: perl(Task::Weaken)
+BuildRequires: perl(Test::More)
+BuildRequires: perl(Tie::RefHash) >= 1.34
+BuildRequires: perl(Variable::Magic)
+Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
%description
The Tie::RefHash module can be used to access hashes by reference. This is
@@ -22,32 +26,36 @@ useful when you index by object, for example.
%setup -q -n Tie-RefHash-Weak-%{version}
%build
-%{__perl} Makefile.PL INSTALLDIRS=vendor
+perl Makefile.PL INSTALLDIRS=vendor
make %{?_smp_mflags}
%install
-rm -rf $RPM_BUILD_ROOT
-
-make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
-
-find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \;
-find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;
-
-%{_fixperms} $RPM_BUILD_ROOT/*
+rm -rf %{buildroot}
+make pure_install DESTDIR=%{buildroot}
+find %{buildroot} -type f -name .packlist -exec rm -f {} ';'
+%{_fixperms} %{buildroot}
%check
make test
%clean
-rm -rf $RPM_BUILD_ROOT
+rm -rf %{buildroot}
%files
-%defattr(-,root,root,-)
%doc Changes TODO
-%{perl_vendorlib}/*
-%{_mandir}/man3/*
+%{perl_vendorlib}/Tie/
+%{_mandir}/man3/Tie::RefHash::Weak.3pm*
%changelog
+* Mon Mar 26 2012 Paul Howarth <paul@xxxxxxxxxxxx> - 0.09-10
+- BR: perl(base), perl(Exporter), perl(Scalar::Util), perl(Tie::RefHash) ≥ 1.34
+- Don't use macros for commands
+- Drop %%defattr, redundant since rpm 4.4
+- Make %%files list more explicit
+- Don't need to remove empty directories from buildroot
+- Use DESTDIR rather than PERL_INSTALL_ROOT
+- Use tabs
+
* Fri Jan 13 2012 Fedora Release Engineering <rel-eng@xxxxxxxxxxxxxxxxxxxxxxx> - 0.09-9
- Rebuilt for https://fedoraproject.org/wiki/Fedora_17_Mass_Rebuild
@@ -58,13 +66,13 @@ rm -rf $RPM_BUILD_ROOT
- Rebuilt for https://fedoraproject.org/wiki/Fedora_15_Mass_Rebuild
* Thu Dec 23 2010 Marcela Maslanova <mmaslano@xxxxxxxxxx> - 0.09-6
-- 661697 rebuild for fixing problems with vendorach/lib
+- Rebuild to fix problems with vendorarch/lib (#661697)
* Fri May 07 2010 Marcela Maslanova <mmaslano@xxxxxxxxxx> - 0.09-5
- Mass rebuild with perl-5.12.0
* Fri Dec 4 2009 Stepan Kasal <skasal@xxxxxxxxxx> - 0.09-4
-- rebuild against perl 5.10.1
+- Rebuild against perl 5.10.1
* Sun Jul 26 2009 Fedora Release Engineering <rel-eng@xxxxxxxxxxxxxxxxxxxxxxx> - 0.09-3
- Rebuilt for https://fedoraproject.org/wiki/Fedora_12_Mass_Rebuild
@@ -72,5 +80,5 @@ rm -rf $RPM_BUILD_ROOT
* Thu Feb 26 2009 Fedora Release Engineering <rel-eng@xxxxxxxxxxxxxxxxxxxxxxx> - 0.09-2
- Rebuilt for https://fedoraproject.org/wiki/Fedora_11_Mass_Rebuild
-* Thu Feb 05 2009 Allisson Azevedo <allisson@xxxxxxxxx> 0.09-1
-- Initial rpm release.
+* Thu Feb 05 2009 Allisson Azevedo <allisson@xxxxxxxxx> - 0.09-1
+- Initial rpm release
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/perl-devel
