commit 475c162bc655e37e5dbed0ddb3e0ea54ec79b597
Author: Paul Howarth <paul@xxxxxxxxxxxx>
Date: Sun Mar 25 13:41:18 2012 +0100
Spec clean-up
- Drop buildreq perl ≥ 0:5.005, satisfied by all Perls in living memory
- Drop redundant buildreq perl(Test::Harness)
- Don't need to remove empty directories from buildroot
- Don't use macros for commands
- Make %files list more explicit
- Use DESTDIR rather than PERL_INSTALL_ROOT
- Use tabs
- Drop %defattr, redundant since rpm 4.4
perl-Test-use-ok.spec | 78 +++++++++++++++++++++++++------------------------
1 files changed, 40 insertions(+), 38 deletions(-)
---
diff --git a/perl-Test-use-ok.spec b/perl-Test-use-ok.spec
index 742a481..a5ec491 100644
--- a/perl-Test-use-ok.spec
+++ b/perl-Test-use-ok.spec
@@ -1,21 +1,16 @@
-Name: perl-Test-use-ok
-Version: 0.02
-Release: 12%{?dist}
-Summary: Alternative to Test::More::use_ok
-License: MIT
-Group: Development/Libraries
-URL: http://search.cpan.org/dist/Test-use-ok/
-Source0: http://www.cpan.org/authors/id/A/AU/AUDREYT/Test-use-ok-%{version}.tar.gz
-BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
-BuildArch: noarch
-BuildRequires: perl >= 0:5.005
-
-# core:
-BuildRequires: perl(ExtUtils::MakeMaker)
-BuildRequires: perl(Test::More)
-BuildRequires: perl(Test::Harness)
-
-Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
+Name: perl-Test-use-ok
+Version: 0.02
+Release: 13%{?dist}
+Summary: Alternative to Test::More::use_ok
+License: MIT
+Group: Development/Libraries
+URL: http://search.cpan.org/dist/Test-use-ok/
+Source0: http://www.cpan.org/authors/id/A/AU/AUDREYT/Test-use-ok-%{version}.tar.gz
+BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(id -nu)
+BuildArch: noarch
+BuildRequires: perl(ExtUtils::MakeMaker)
+BuildRequires: perl(Test::More)
+Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
%description
According to the Test::More documentation, it is recommended to run
@@ -34,18 +29,14 @@ makes it clear that this is a single compile-time action.
%setup -q -n Test-use-ok-%{version}
%build
-%{__perl} Makefile.PL INSTALLDIRS=vendor
+perl Makefile.PL INSTALLDIRS=vendor
make %{?_smp_mflags}
%install
rm -rf %{buildroot}
-
-make pure_install PERL_INSTALL_ROOT=%{buildroot}
-
+make pure_install DESTDIR=%{buildroot}
find %{buildroot} -type f -name .packlist -exec rm -f {} \;
-find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null \;
-
-%{_fixperms} %{buildroot}/*
+%{_fixperms} %{buildroot}
%check
make test
@@ -54,12 +45,23 @@ make test
rm -rf %{buildroot}
%files
-%defattr(-,root,root,-)
%doc Changes README t/
-%{perl_vendorlib}/*
-%{_mandir}/man3/*
+%{perl_vendorlib}/ok.pm
+%{perl_vendorlib}/Test/
+%{_mandir}/man3/Test::use::ok.3pm*
+%{_mandir}/man3/ok.3pm*
%changelog
+* Sun Mar 25 2012 Paul Howarth <paul@xxxxxxxxxxxx> - 0.02-13
+- Drop buildreq perl ≥ 0:5.005, satisfied by all Perls in living memory
+- Drop redundant buildreq perl(Test::Harness)
+- Don't need to remove empty directories from buildroot
+- Don't use macros for commands
+- Make %%files list more explicit
+- Use DESTDIR rather than PERL_INSTALL_ROOT
+- Use tabs
+- Drop %%defattr, redundant since rpm 4.4
+
* Fri Jan 13 2012 Fedora Release Engineering <rel-eng@xxxxxxxxxxxxxxxxxxxxxxx> - 0.02-12
- Rebuilt for https://fedoraproject.org/wiki/Fedora_17_Mass_Rebuild
@@ -70,13 +72,13 @@ rm -rf %{buildroot}
- Rebuilt for https://fedoraproject.org/wiki/Fedora_15_Mass_Rebuild
* Wed Dec 22 2010 Marcela Maslanova <mmaslano@xxxxxxxxxx> - 0.02-9
-- 661697 rebuild for fixing problems with vendorach/lib
+- Rebuild to fix problems with vendorarch/lib (#661697)
* Fri May 07 2010 Marcela Maslanova <mmaslano@xxxxxxxxxx> - 0.02-8
- Mass rebuild with perl-5.12.0
* Fri Dec 4 2009 Stepan Kasal <skasal@xxxxxxxxxx> - 0.02-7
-- rebuild against perl 5.10.1
+- Rebuild against perl 5.10.1
* Sun Jul 26 2009 Fedora Release Engineering <rel-eng@xxxxxxxxxxxxxxxxxxxxxxx> - 0.02-6
- Rebuilt for https://fedoraproject.org/wiki/Fedora_12_Mass_Rebuild
@@ -84,14 +86,14 @@ rm -rf %{buildroot}
* Thu Feb 26 2009 Fedora Release Engineering <rel-eng@xxxxxxxxxxxxxxxxxxxxxxx> - 0.02-5
- Rebuilt for https://fedoraproject.org/wiki/Fedora_11_Mass_Rebuild
-* Wed Mar 5 2008 Tom "spot" Callaway <tcallawa@xxxxxxxxxx> 0.02-4
-- rebuild for new perl
+* Wed Mar 5 2008 Tom "spot" Callaway <tcallawa@xxxxxxxxxx> - 0.02-4
+- Rebuild for new perl
-* Mon Apr 30 2007 Chris Weyl <cweyl@xxxxxxxxxxxxxxx> 0.02-3
-- bump
+* Mon Apr 30 2007 Chris Weyl <cweyl@xxxxxxxxxxxxxxx> - 0.02-3
+- Bump
-* Tue Apr 10 2007 Chris Weyl <cweyl@xxxxxxxxxxxxxxx> 0.02-2
-- updated with core modules as BR's
+* Tue Apr 10 2007 Chris Weyl <cweyl@xxxxxxxxxxxxxxx> - 0.02-2
+- Updated with core modules as BR's
-* Tue Apr 10 2007 Chris Weyl <cweyl@xxxxxxxxxxxxxxx> 0.02-1
-- Specfile autogenerated by cpanspec 1.70.
+* Tue Apr 10 2007 Chris Weyl <cweyl@xxxxxxxxxxxxxxx> - 0.02-1
+- Specfile autogenerated by cpanspec 1.70
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/perl-devel
