commit fc4da8936ee6341a05420a021b5488d960df0417
Author: Paul Howarth <paul@xxxxxxxxxxxx>
Date: Wed Mar 21 10:59:45 2012 +0000
Drop tests subpackage and clean up
- Drop -tests subpackage (general lack of interest in this), but include
them as documentation for the main package
- Drop redundant BR: perl(ExtUtils::MakeMaker)
- Drop redundant unversioned explicit requires
- Drop %defattr, redundant since rpm 4.4
- Make %files list more explicit
- Don't use macros for commands
- Run the author tests in %check
- BR: perl(Test::Pod) and perl(Test::Pod::Coverage)
- Use tabs
perl-Test-Perl-Critic.spec | 155 ++++++++++++++++++++++----------------------
1 files changed, 78 insertions(+), 77 deletions(-)
---
diff --git a/perl-Test-Perl-Critic.spec b/perl-Test-Perl-Critic.spec
index 3a2a9d5..638ef13 100644
--- a/perl-Test-Perl-Critic.spec
+++ b/perl-Test-Perl-Critic.spec
@@ -1,35 +1,34 @@
-Name: perl-Test-Perl-Critic
-Summary: Use Perl::Critic in test programs
-Version: 1.02
-Release: 6%{?dist}
-License: GPL+ or Artistic
-Group: Development/Libraries
-Source0: http://search.cpan.org/CPAN/authors/id/T/TH/THALJEF/Test-Perl-Critic-%{version}.tar.gz
-URL: http://search.cpan.org/dist/Test-Perl-Critic/
-BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
-Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
-BuildArch: noarch
-
-BuildRequires: perl(Carp)
-BuildRequires: perl(English)
-BuildRequires: perl(ExtUtils::MakeMaker)
-BuildRequires: perl(Module::Build) >= 0.35
-BuildRequires: perl(Perl::Critic) >= 1.105
-BuildRequires: perl(Perl::Critic::Utils) >= 1.105
-BuildRequires: perl(Perl::Critic::Violation) >= 1.105
-BuildRequires: perl(Test::Builder)
-BuildRequires: perl(Test::More)
-
-Requires: perl(Carp)
-Requires: perl(English)
-Requires: perl(Perl::Critic) >= 1.105
-Requires: perl(Perl::Critic::Utils) >= 1.105
-Requires: perl(Perl::Critic::Violation) >= 1.105
-Requires: perl(Test::Builder)
-
-
+Name: perl-Test-Perl-Critic
+Summary: Use Perl::Critic in test programs
+Version: 1.02
+Release: 7%{?dist}
+Group: Development/Libraries
+License: GPL+ or Artistic
+URL: http://search.cpan.org/dist/Test-Perl-Critic/
+Source0: http://search.cpan.org/CPAN/authors/id/T/TH/THALJEF/Test-Perl-Critic-%{version}.tar.gz
+BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(id -nu)
+BuildArch: noarch
+BuildRequires: perl(Carp)
+BuildRequires: perl(English)
+BuildRequires: perl(Module::Build) >= 0.35
+BuildRequires: perl(Perl::Critic) >= 1.105
+BuildRequires: perl(Perl::Critic::Utils) >= 1.105
+BuildRequires: perl(Perl::Critic::Violation) >= 1.105
+BuildRequires: perl(Test::Builder)
+BuildRequires: perl(Test::More)
+BuildRequires: perl(Test::Pod)
+BuildRequires: perl(Test::Pod::Coverage)
+Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
+Requires: perl(Perl::Critic) >= 1.105
+Requires: perl(Perl::Critic::Utils) >= 1.105
+Requires: perl(Perl::Critic::Violation) >= 1.105
+
+# Avoid doc-file dependencies from tests
%{?perl_default_filter}
-%{?perl_default_subpackage_tests}
+
+# Obsolete/provide old -tests subpackage (can be removed in F19 development cycle)
+Obsoletes: %{name}-tests < %{version}-%{release}
+Provides: %{name}-tests = %{version}-%{release}
%description
Test::Perl::Critic wraps the Perl::Critic engine in a convenient
@@ -38,40 +37,42 @@ framework. This makes it easy to integrate coding-standards enforcement
into the build process. For ultimate convenience (at the expense of some
flexibility), see the criticism pragma.
-
%prep
%setup -q -n Test-Perl-Critic-%{version}
-
%build
-%{__perl} Build.PL installdirs=vendor
+perl Build.PL installdirs=vendor
./Build
-
%install
-rm -rf $RPM_BUILD_ROOT
-./Build install destdir=$RPM_BUILD_ROOT create_packlist=0
-%{_fixperms} $RPM_BUILD_ROOT/*
-
+rm -rf %{buildroot}
+./Build install destdir=%{buildroot} create_packlist=0
+%{_fixperms} %{buildroot}
%check
-# Tests are failing with odd unpack errors.
-# TEST_AUTHOR=1 ./Build test
-./Build test
-
+TEST_AUTHOR=1 ./Build test
%clean
-rm -rf $RPM_BUILD_ROOT
-
+rm -rf %{buildroot}
%files
-%defattr(-,root,root,-)
-%doc Changes LICENSE README
+%doc Changes LICENSE README %{?perl_default_filter:t/ xt/}
%{perl_vendorlib}/Test/
-%{_mandir}/man3/*.3pm*
-
+%{_mandir}/man3/Test::Perl::Critic.3pm*
%changelog
+* Wed Mar 21 2012 Paul Howarth <paul@xxxxxxxxxxxx> - 1.02-7
+- Drop -tests subpackage (general lack of interest in this), but include
+ them as documentation for the main package
+- Drop redundant BR: perl(ExtUtils::MakeMaker)
+- Drop redundant unversioned explicit requires
+- Drop %%defattr, redundant since rpm 4.4
+- Make %%files list more explicit
+- Don't use macros for commands
+- Run the author tests in %%check
+- BR: perl(Test::Pod) and perl(Test::Pod::Coverage)
+- Use tabs
+
* Fri Jan 13 2012 Fedora Release Engineering <rel-eng@xxxxxxxxxxxxxxxxxxxxxxx> - 1.02-6
- Rebuilt for https://fedoraproject.org/wiki/Fedora_17_Mass_Rebuild
@@ -82,34 +83,34 @@ rm -rf $RPM_BUILD_ROOT
- Rebuilt for https://fedoraproject.org/wiki/Fedora_15_Mass_Rebuild
* Wed Dec 22 2010 Marcela Maslanova <mmaslano@xxxxxxxxxx> - 1.02-3
-- 661697 rebuild for fixing problems with vendorach/lib
+- Rebuild to fix problems with vendorarch/lib (#661697)
* Fri May 07 2010 Marcela Maslanova <mmaslano@xxxxxxxxxx> - 1.02-2
- Mass rebuild with perl-5.12.0
-* Sun Mar 14 2010 Chris Weyl <cweyl@xxxxxxxxxxxxxxx> 1.02-1
-- update by Fedora::App::MaintainerTools 0.006
-- updating to latest GA CPAN version (1.02)
-- added a new br on perl(Carp) (version 0)
-- added a new br on perl(English) (version 0)
-- altered br on perl(Module::Build) (0 => 0.35)
-- altered br on perl(Perl::Critic) (0.21 => 1.105)
-- added a new br on perl(Perl::Critic::Utils) (version 1.105)
-- added a new br on perl(Perl::Critic::Violation) (version 1.105)
-- added a new br on perl(Test::Builder) (version 0)
-- added a new br on perl(Test::More) (version 0)
-- force-adding ExtUtils::MakeMaker as a BR
-- dropped old BR on perl(Test::Pod)
-- dropped old BR on perl(Test::Pod::Coverage)
-- added a new req on perl(Carp) (version 0)
-- added a new req on perl(English) (version 0)
-- added a new req on perl(Perl::Critic) (version 1.105)
-- added a new req on perl(Perl::Critic::Utils) (version 1.105)
-- added a new req on perl(Perl::Critic::Violation) (version 1.105)
-- added a new req on perl(Test::Builder) (version 0)
+* Sun Mar 14 2010 Chris Weyl <cweyl@xxxxxxxxxxxxxxx> - 1.02-1
+- Update by Fedora::App::MaintainerTools 0.006
+- Updating to latest GA CPAN version (1.02)
+- Added a new br on perl(Carp) (version 0)
+- Added a new br on perl(English) (version 0)
+- Altered br on perl(Module::Build) (0 => 0.35)
+- Altered br on perl(Perl::Critic) (0.21 => 1.105)
+- Added a new br on perl(Perl::Critic::Utils) (version 1.105)
+- Added a new br on perl(Perl::Critic::Violation) (version 1.105)
+- Added a new br on perl(Test::Builder) (version 0)
+- Added a new br on perl(Test::More) (version 0)
+- Force-adding ExtUtils::MakeMaker as a BR
+- Dropped old BR on perl(Test::Pod)
+- Dropped old BR on perl(Test::Pod::Coverage)
+- Added a new req on perl(Carp) (version 0)
+- Added a new req on perl(English) (version 0)
+- Added a new req on perl(Perl::Critic) (version 1.105)
+- Added a new req on perl(Perl::Critic::Utils) (version 1.105)
+- Added a new req on perl(Perl::Critic::Violation) (version 1.105)
+- Added a new req on perl(Test::Builder) (version 0)
* Fri Dec 4 2009 Stepan Kasal <skasal@xxxxxxxxxx> - 1.01-8
-- rebuild against perl 5.10.1
+- Rebuild against perl 5.10.1
* Sun Jul 26 2009 Fedora Release Engineering <rel-eng@xxxxxxxxxxxxxxxxxxxxxxx> - 1.01-7
- Rebuilt for https://fedoraproject.org/wiki/Fedora_12_Mass_Rebuild
@@ -121,19 +122,19 @@ rm -rf $RPM_BUILD_ROOT
- Rebuild for perl 5.10 (again)
* Tue Jan 15 2008 Tom "spot" Callaway <tcallawa@xxxxxxxxxx> - 1.01-4
-- disable tests, take out patch, doesn't fix test failures
+- Disable tests, take out patch, doesn't fix test failures
* Tue Jan 15 2008 Tom "spot" Callaway <tcallawa@xxxxxxxxxx> - 1.01-3
-- patch for test failure
+- Patch for test failure
* Mon Jan 14 2008 Tom "spot" Callaway <tcallawa@xxxxxxxxxx> - 1.01-2
-- rebuild for new perl
+- Rebuild for new perl
* Sat Jan 27 2007 Jose Pedro Oliveira <jpo at di.uminho.pt> - 1.01-1
-- Update to 1.01.
+- Update to 1.01
* Sun Nov 12 2006 Jose Pedro Oliveira <jpo at di.uminho.pt> - 0.08-1
-- Update to 0.08.
+- Update to 0.08
* Sat Sep 23 2006 Jose Pedro Oliveira <jpo at di.uminho.pt> - 0.07-1
-- First build.
+- First build
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/perl-devel
