commit a97f7cb24656bbab33cae80e5e19575fd9eb58b2
Author: Paul Howarth <paul@xxxxxxxxxxxx>
Date: Tue Mar 6 20:14:38 2012 +0000
Spec clean-up
- BR: perl(Carp) and perl(version)
- Don't need to remove empty directories from buildroot
- Don't use macros for commands
- Explicitly run the Pod tests
- Make %files list more explicit
- Package example
- Drop %defattr, redundant since rpm 4.4
.gitignore | 5 ++++-
perl-Module-ExtractUse.spec | 32 ++++++++++++++++++++------------
2 files changed, 24 insertions(+), 13 deletions(-)
---
diff --git a/.gitignore b/.gitignore
index 6fcbb75..aa4a9d9 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1 +1,4 @@
-Module-ExtractUse-0.23.tar.gz
+*.tar.gz
+.build*.log
+noarch/
+*.src.rpm
diff --git a/perl-Module-ExtractUse.spec b/perl-Module-ExtractUse.spec
index 8699db4..4c7a2d9 100644
--- a/perl-Module-ExtractUse.spec
+++ b/perl-Module-ExtractUse.spec
@@ -1,13 +1,14 @@
Name: perl-Module-ExtractUse
Version: 0.23
-Release: 3%{?dist}
+Release: 4%{?dist}
Summary: Find out what modules are used
License: GPL+ or Artistic
Group: Development/Libraries
URL: http://search.cpan.org/dist/Module-ExtractUse/
Source0: http://www.cpan.org/modules/by-module/Module/Module-ExtractUse-%{version}.tar.gz
-BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
+BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(id -nu)
BuildArch: noarch
+BuildRequires: perl(Carp)
BuildRequires: perl(Module::Build)
BuildRequires: perl(Parse::RecDescent) >= 1.94
BuildRequires: perl(Pod::Strip) >= 1.00
@@ -16,7 +17,8 @@ BuildRequires: perl(Test::NoWarnings)
BuildRequires: perl(Test::Pod)
BuildRequires: perl(Test::Pod::Coverage)
BuildRequires: perl(UNIVERSAL::require)
-Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
+BuildRequires: perl(version)
+Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
%description
Module::ExtractUse is basically a Parse::RecDescent grammar to parse Perl
@@ -27,33 +29,39 @@ from CPAN) used by the parsed code.
%setup -q -n Module-ExtractUse-%{version}
%build
-%{__perl} Build.PL installdirs=vendor
+perl Build.PL installdirs=vendor
./Build
%install
rm -rf $RPM_BUILD_ROOT
-
./Build install destdir=$RPM_BUILD_ROOT create_packlist=0
-find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;
-
-%{_fixperms} $RPM_BUILD_ROOT/*
+%{_fixperms} $RPM_BUILD_ROOT
%check
./Build test
+./Build test --test_files="xt/*.t"
%clean
rm -rf $RPM_BUILD_ROOT
%files
-%defattr(-,root,root,-)
-%doc Changes README TODO
-%dir %{perl_vendorlib}/Module
+%doc Changes README TODO example/
+%dir %{perl_vendorlib}/Module/
%{perl_vendorlib}/Module/ExtractUse.pm
%dir %{perl_vendorlib}/Module/ExtractUse/
%{perl_vendorlib}/Module/ExtractUse/Grammar.pm
-%{_mandir}/man3/*.3pm*
+%{_mandir}/man3/Module::ExtractUse.3pm*
%changelog
+* Tue Mar 6 2012 Paul Howarth <paul@xxxxxxxxxxxx> - 0.23-4
+- BR: perl(Carp) and perl(version)
+- Don't need to remove empty directories from buildroot
+- Don't use macros for commands
+- Explicitly run the Pod tests
+- Make %%files list more explicit
+- Package example
+- Drop %%defattr, redundant since rpm 4.4
+
* Sun Jul 26 2009 Fedora Release Engineering <rel-eng@xxxxxxxxxxxxxxxxxxxxxxx> - 0.23-3
- Rebuilt for https://fedoraproject.org/wiki/Fedora_12_Mass_Rebuild
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/perl-devel
