commit edac6fde7a1291e8c7b2c9eae180889b035f18f1
Author: Paul Howarth <paul@xxxxxxxxxxxx>
Date: Mon Mar 5 15:51:28 2012 +0000
Spec clean-up
- Use %{optflags}
- BR: perl(Exporter) and perl(Test::Pod)
- Make %files list more explicit
- Use DESTDIR rather than PERL_INSTALL_ROOT
- No need to remove empty directories from buildroot
- Don't use macros for commands
- Use tabs
.gitignore | 2 +-
perl-Sub-Identify.spec | 105 ++++++++++++++++++++++++++----------------------
2 files changed, 58 insertions(+), 49 deletions(-)
---
diff --git a/.gitignore b/.gitignore
index 081d739..fc0afde 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1 +1 @@
-Sub-Identify-0.04.tar.gz
+/Sub-Identify-[0-9.]*.tar.gz
diff --git a/perl-Sub-Identify.spec b/perl-Sub-Identify.spec
index d184b3a..3273671 100644
--- a/perl-Sub-Identify.spec
+++ b/perl-Sub-Identify.spec
@@ -1,41 +1,41 @@
-Name: perl-Sub-Identify
-Version: 0.04
-Release: 12%{?dist}
-Summary: Retrieve names of code references
-License: GPL+ or Artistic
-Group: Development/Libraries
-URL: http://search.cpan.org/dist/Sub-Identify/
-Source0: http://www.cpan.org/authors/id/R/RG/RGARCIA/Sub-Identify-%{version}.tar.gz
-BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
-BuildRequires: perl(ExtUtils::MakeMaker)
-BuildRequires: perl(Test::More)
-Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
-
+Name: perl-Sub-Identify
+Version: 0.04
+Release: 13%{?dist}
+Summary: Retrieve names of code references
+License: GPL+ or Artistic
+Group: Development/Libraries
+URL: http://search.cpan.org/dist/Sub-Identify/
+Source0: http://search.cpan.org/CPAN/authors/id/R/RG/RGARCIA/Sub-Identify-%{version}.tar.gz
+BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(id -nu)
+BuildRequires: perl(Exporter)
+BuildRequires: perl(ExtUtils::MakeMaker)
+BuildRequires: perl(Test::More)
+BuildRequires: perl(Test::Pod)
+Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
+
+# Don't provide private perl libs
%{?perl_default_filter}
%description
Sub::Identify allows you to retrieve the real name of code references. For
-this, it uses perl's introspection mechanism, provided by the B module.
+this, it uses Perl's introspection mechanism, provided by the B module.
%prep
%setup -q -n Sub-Identify-%{version}
-perl -pi -e 's|^#!perl|#!%{__perl}|' t/*
+# Fix script interpreters
+perl -pi -e 's|^#!perl|#!/usr/bin/perl|' t/*
%build
-%{__perl} Makefile.PL INSTALLDIRS=vendor
+perl Makefile.PL INSTALLDIRS=vendor OPTIMIZE="%{optflags}"
make %{?_smp_mflags}
%install
rm -rf %{buildroot}
-
-make pure_install PERL_INSTALL_ROOT=%{buildroot}
-
-find %{buildroot} -type f -name .packlist -exec rm -f {} \;
+make pure_install DESTDIR=%{buildroot}
+find %{buildroot} -type f -name .packlist -exec rm -f {} ';'
find %{buildroot} -type f -name '*.bs' -a -size 0 -exec rm -f {} ';'
-find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null \;
-
-%{_fixperms} %{buildroot}/*
+%{_fixperms} %{buildroot}
%check
make test
@@ -46,11 +46,20 @@ rm -rf %{buildroot}
%files
%defattr(-,root,root,-)
%doc Changes t/
-%{perl_vendorarch}/*
-%exclude %dir %{perl_vendorarch}/auto/
-%{_mandir}/man3/*.3*
+%{perl_vendorarch}/auto/Sub/
+%{perl_vendorarch}/Sub/
+%{_mandir}/man3/Sub::Identify.3pm*
%changelog
+* Mon Mar 5 2012 Paul Howarth <paul@xxxxxxxxxxxx> - 0.04-13
+- Use %%{optflags}
+- BR: perl(Exporter) and perl(Test::Pod)
+- Make %%files list more explicit
+- Use DESTDIR rather than PERL_INSTALL_ROOT
+- No need to remove empty directories from buildroot
+- Don't use macros for commands
+- Use tabs
+
* Fri Jan 13 2012 Fedora Release Engineering <rel-eng@xxxxxxxxxxxxxxxxxxxxxxx> - 0.04-12
- Rebuilt for https://fedoraproject.org/wiki/Fedora_17_Mass_Rebuild
@@ -61,16 +70,16 @@ rm -rf %{buildroot}
- Rebuilt for https://fedoraproject.org/wiki/Fedora_15_Mass_Rebuild
* Wed Dec 22 2010 Marcela Maslanova <mmaslano@xxxxxxxxxx> - 0.04-9
-- 661697 rebuild for fixing problems with vendorach/lib
+- Rebuild to fix problems with vendorarch/lib (#661697)
* Thu May 06 2010 Marcela Maslanova <mmaslano@xxxxxxxxxx> - 0.04-8
- Mass rebuild with perl-5.12.0
* Mon Dec 7 2009 Stepan Kasal <skasal@xxxxxxxxxx> - 0.04-7
-- rebuild against perl 5.10.1
+- Rebuild against perl 5.10.1
-* Fri Aug 28 2009 Chris Weyl <cweyl@xxxxxxxxxxxxxxx> 0.04-6
-- bump
+* Fri Aug 28 2009 Chris Weyl <cweyl@xxxxxxxxxxxxxxx> - 0.04-6
+- Bump
* Thu Aug 27 2009 Chris Weyl <cweyl@xxxxxxxxxxxxxxx> - 0.04-5
- Filtering errant private provides
@@ -81,28 +90,28 @@ rm -rf %{buildroot}
* Thu Feb 26 2009 Fedora Release Engineering <rel-eng@xxxxxxxxxxxxxxxxxxxxxxx> - 0.04-3
- Rebuilt for https://fedoraproject.org/wiki/Fedora_11_Mass_Rebuild
-* Wed Feb 11 2009 Chris Weyl <cweyl@xxxxxxxxxxxxxxx> 0.04-2
-- aaaand change files to look in the the arch-dependent dirs
+* Wed Feb 11 2009 Chris Weyl <cweyl@xxxxxxxxxxxxxxx> - 0.04-2
+- Aaaand change files to look in the the arch-dependent dirs
-* Wed Feb 11 2009 Chris Weyl <cweyl@xxxxxxxxxxxxxxx> 0.04-1
-- update to 0.04
-- drop buildarch noarch, as we have some XS bits now
+* Wed Feb 11 2009 Chris Weyl <cweyl@xxxxxxxxxxxxxxx> - 0.04-1
+- Update to 0.04
+- Drop buildarch noarch, as we have some XS bits now
-* Wed May 28 2008 Chris Weyl <cweyl@xxxxxxxxxxxxxxx> 0.03-1
-- update to 0.03
+* Wed May 28 2008 Chris Weyl <cweyl@xxxxxxxxxxxxxxx> - 0.03-1
+- Update to 0.03
-* Tue Mar 04 2008 Tom "spot" Callaway <tcallawa@xxxxxxxxxx> 0.02-3
-- rebuild for new perl
+* Tue Mar 04 2008 Tom "spot" Callaway <tcallawa@xxxxxxxxxx> - 0.02-3
+- Rebuild for new perl
-* Tue Oct 16 2007 Tom "spot" Callaway <tcallawa@xxxxxxxxxx> 0.02-2.2
-- add BR: perl(Test::More)
+* Tue Oct 16 2007 Tom "spot" Callaway <tcallawa@xxxxxxxxxx> - 0.02-2.2
+- Add BR: perl(Test::More)
-* Tue Oct 16 2007 Tom "spot" Callaway <tcallawa@xxxxxxxxxx> 0.02-2.1
-- correct license tag
-- add BR: perl(ExtUtils::MakeMaker)
+* Tue Oct 16 2007 Tom "spot" Callaway <tcallawa@xxxxxxxxxx> - 0.02-2.1
+- Correct license tag
+- Add BR: perl(ExtUtils::MakeMaker)
-* Wed Sep 06 2006 Chris Weyl <cweyl@xxxxxxxxxxxxxxx> 0.02-2
-- bump
+* Wed Sep 06 2006 Chris Weyl <cweyl@xxxxxxxxxxxxxxx> - 0.02-2
+- Bump
-* Tue Sep 05 2006 Chris Weyl <cweyl@xxxxxxxxxxxxxxx> 0.02-1
-- Specfile autogenerated by cpanspec 1.69.1.
+* Tue Sep 05 2006 Chris Weyl <cweyl@xxxxxxxxxxxxxxx> - 0.02-1
+- Specfile autogenerated by cpanspec 1.69.1
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/perl-devel
