Re: [perl-Devel-Caller] RPM 4.9 dependency filtering added

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 25, 2011 at 04:53:52PM +0200, Iain Arnell wrote:
> On Mon, Jul 25, 2011 at 11:32 AM, Petr Sabata <psabata@xxxxxxxxxxxxxxxxx> wrote:
> > commit 18c2b80686fdfe615681f2e9657dd0d88d16b44f
> > Author: Petr Pisar <ppisar@xxxxxxxxxx>
> > Date:   Mon Jul 25 11:27:37 2011 +0200
> >
> >    RPM 4.9 dependency filtering added
> >
> >  perl-Devel-Caller.spec |   10 ++++++++--
> >  1 files changed, 8 insertions(+), 2 deletions(-)
> > ---
> > diff --git a/perl-Devel-Caller.spec b/perl-Devel-Caller.spec
> > index 3478963..e382f30 100644
> > --- a/perl-Devel-Caller.spec
> > +++ b/perl-Devel-Caller.spec
> > @@ -1,6 +1,6 @@
> >  Name:           perl-Devel-Caller
> >  Version:        2.05
> > -Release:        5%{?dist}
> > +Release:        6%{?dist}
> >  Summary:        Meatier versions of caller
> >  License:        GPL+ or Artistic
> >  Group:          Development/Libraries
> > @@ -13,10 +13,13 @@ BuildRequires:  perl(Test::More)
> >  Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
> >
> >  # Don't provide Caller.so or perl(DB)
> > +# RPM 4.8 style
> >  %{?filter_setup:
> >  %filter_from_provides /^perl(DB)/d
> > -%?perl_default_filter
> >  }
> > +# RPM 4.9 style
> > +%global __provides_exclude %{?__provides_exclude:__provides_exclude|}^perl\\(DB\\)
> > +%{?perl_default_filter}
> 
> Petr,
> 
> perl_default_filter simply sets __provides_exclude - it doesn't append
> to it. You need to extend __provides_exclude after doing
> perl_default_filter. Fixed in git.
> 
You are right. I forgot it's not relocatable as former implementation.

Actually this should be fixed somehow in perl otherwise there will be problems
when mixing default filters from different languages.

-- Petr

Attachment: pgpX8ePb5T8rE.pgp
Description: PGP signature

--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/perl-devel

[Index of Archives]     [Fedora Announce]     [Fedora Kernel]     [Fedora Testing]     [Fedora Legacy Announce]     [Fedora PHP Devel]     [Kernel Devel]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Big List of Linux Books]     [Gimp]     [Yosemite Information]
  Powered by Linux