Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=630644 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #17 from Petr Pisar <ppisar@xxxxxxxxxx> 2011-03-21 07:05:08 EDT --- Changed in SPEC file: --- perl-Bio-SamTools.spec 2011-03-14 22:52:48.000000000 +0100 +++ perl-Bio-SamTools.spec.1 2011-03-18 13:56:12.000000000 +0100 @@ -1,8 +1,8 @@ Name: perl-Bio-SamTools Version: 1.27 -Release: 1%{?dist} +Release: 2%{?dist} Summary: Bio::SamTools Perl module -License: Artistic 2.0 +License: GPL+ or Artistic 2.0 Group: Development/Libraries URL: http://search.cpan.org/dist/Bio-SamTools/ Source0: http://search.cpan.org/CPAN/authors/id/L/LD/LDS/Bio-SamTools-%{version}.tar.gz @@ -21,7 +21,7 @@ BuildRequires: samtools-devel >= 0.1.8 BuildRequires: zlib-devel -Requires: perl-bioperl +#Requires: perl-bioperl Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) %{?perl_default_filter} @@ -63,6 +63,9 @@ %{_bindir}/bamToGBrowse.pl %changelog +* Fri Mar 18 2011 Adam Huffman <bloch@xxxxxxxxxxxx> - 1.27-2 +- remove perl-bioperl reqs. and fix license + * Mon Mar 14 2011 Adam Huffman <bloch@xxxxxxxxxxxx> - 1.27-1 - new upstream version 1.27 - remove unnecessary runtime samtools-devel R > FIX: The package is dual-licensed. User can select between GPL+ and Artistic > 2.0. Please mention both licenses in the License tag. -License: Artistic 2.0 +License: GPL+ or Artistic 2.0 Ok. > FIX: Is the dependency on perl-bioperl required? In other words, is explicit > `Requires: perl-bioperl' statement in spec file needed? Does this package use > some scripts or data files directly from perl-bioperl? Or are autodiscovered > perl() dependencies, that are part of perl-bioperl, sufficient?. If the later > is true, remove the Requires statement from spec file. -Requires: perl-bioperl +#Requires: perl-bioperl Ok. $ rpmlint perl-Bio-SamTools.spec ../SRPMS/perl-Bio-SamTools-1.27-2.fc14.src.rpm ../RPMS/x86_64/perl-Bio-SamTools-*1.27-2.* perl-Bio-SamTools.x86_64: W: no-manual-page-for-binary bamToGBrowse.pl 3 packages and 1 specfiles checked; 0 errors, 1 warnings. rpmlint Ok. $ rpm -q --requires -p ../RPMS/x86_64/perl-Bio-SamTools-1.27-2.fc14.x86_64.rpm |sort |uniq -c 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.3.4)(64bit) 1 libc.so.6(GLIBC_2.3)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 libc.so.6(GLIBC_2.7)(64bit) 1 libc.so.6()(64bit) 1 libgcc_s.so.1(GCC_3.0)(64bit) 1 libgcc_s.so.1(GCC_3.3.1)(64bit) 1 libgcc_s.so.1()(64bit) 1 libz.so.1(ZLIB_1.2.2)(64bit) 1 libz.so.1(ZLIB_1.2.3.3)(64bit) 1 libz.so.1()(64bit) 1 perl(base) 1 perl(Bio::DB::Bam::Alignment) 1 perl(Bio::DB::Bam::AlignWrapper) 1 perl(Bio::DB::Bam::FetchIterator) 1 perl(Bio::DB::Bam::PileupWrapper) 1 perl(Bio::DB::Bam::Query) 1 perl(Bio::DB::Bam::ReadIterator) 1 perl(Bio::DB::Bam::Target) 1 perl(Bio::DB::Sam) 1 perl(Bio::DB::Sam::Constants) 1 perl(Bio::DB::Sam::SamToGBrowse) 1 perl(Bio::DB::Sam::Segment) 1 perl(Bio::PrimarySeq) 1 perl(Bio::SeqFeature::Lite) 1 perl(Carp) 1 perl(constant) 1 perl(Cwd) 1 perl(Exporter) 1 perl(File::Basename) 1 perl(File::Spec) 1 perl(File::Temp) 1 perl(:MODULE_COMPAT_5.12.3) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 2 rpmlib(VersionedDependencies) <= 3.0.3-1 1 rtld(GNU_HASH) 1 /usr/bin/perl Binary requires are Ok. $ resolvedeps-f16 ../RPMS/x86_64/perl-Bio-SamTools-1.27-2.fc14.x86_64.rpm Binary dependencies resolvable. Ok. Package builds in F16 (http://koji.fedoraproject.org/koji/taskinfo?taskID=2928058). Ok. Package is in line with Fedora and perl packaging guidelines. Resolution: Package APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. -- Fedora Extras Perl SIG http://www.fedoraproject.org/wiki/Extras/SIGs/Perl perl-devel mailing list perl-devel@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/perl-devel
