Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=552564 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> 2010-01-15 01:52:08 EST --- Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1923072 - rpmlint is NOT silent for SRPM and for RPM. perl-IO-stringy.noarch: W: spurious-executable-perm /usr/share/doc/perl-IO-stringy-2.110/examples/IO_Scalar_synopsis perl-IO-stringy.noarch: W: doc-file-dependency /usr/share/doc/perl-IO-stringy-2.110/examples/IO_Scalar_synopsis /usr/bin/perl + source files match upstream url (sha1sum) 3ef94404e51e3a6276ddddcce9ba7bbdd6b76a1f IO-stringy-2.110.tar.gz + package meets naming and packaging guidelines. + make test gave All tests successful. Files=6, Tests=116, 0 wallclock secs ( 0.03 usr 0.01 sys + 0.18 cusr 0.02 csys = 0.24 CPU) + Package perl-IO-stringy-2.110-11.fc13.noarch => Provides: perl(IO::AtomicFile) = 2.110 perl(IO::InnerFile) = 2.110 perl(IO::Lines) = 2.110 perl(IO::Scalar) = 2.110 perl(IO::ScalarArray) = 2.110 perl(IO::Stringy) = 2.110 perl(IO::Wrap) = 2.110 perl(IO::WrapTie) = 2.110 perl(IO::WrapTie::Master) perl(IO::WrapTie::Slave) Requires: /usr/bin/perl perl >= 0:5.002 perl >= 0:5.004 perl >= 0:5.005 perl(Carp) perl(Exporter) perl(FileHandle) perl(IO::File) perl(IO::Handle) perl(IO::Scalar) perl(IO::ScalarArray) perl(IO::WrapTie) perl(Symbol) perl(overload) perl(strict) perl(vars) Suggestions: 1) please use macros everywhere so replace rm in following with its macro /usr/bin/find %{buildroot} -type f -name .packlist -exec rm -f {} ';' 2)change line %{__chmod} -R u+w %{buildroot}/* to %{_fixperms} %{buildroot}/* 3) Fix rpmlint message by adding following to %prep chmod 644 examples/IO_Scalar_synopsis APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. -- Fedora Extras Perl SIG http://www.fedoraproject.org/wiki/Extras/SIGs/Perl perl-devel mailing list perl-devel@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/perl-devel
