Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=552554 --- Comment #2 from Paul Howarth <paul@xxxxxxxxxxxx> 2010-01-14 15:37:38 EST --- (In reply to comment #1) > MUST items: > > [YES] rpmlint is silent: > > $ rpmlint ./perl-Convert-BinHex.spec > perl-Convert-BinHex-1.119-11.fc13.noarch.rpm > perl-Convert-BinHex-1.119-11.fc13.src.rpm > 2 packages and 1 specfiles checked; 0 errors, 0 warnings. > > [YES] Package meets naming and packaging guidelines. > [YES] Spec file matches the base package name. > > [NOT SURE] Meets licensing guidelines. > [NO] License specified in spec file and matches. > - CPAN says: Unknown license > - included COPYING contains text of GPLv1 > - spec file says: GPL+ or Artistic lib/Convert/BinHex.pm (the actual code) says (near the end): Copyright (c) 1997 by Eryq. All rights reserved. This program is free software; you can redistribute it and/or modify it under the same terms as Perl itself. This makes it GPL+ or Artistic > [YES] Spec file in American English. > [YES] Spec file is legible. > > [NO] Spec file uses macros consistently. > - %install section contains > /usr/bin/find %{buildroot} -type f -name .packlist -exec rm -f {} ';' > while few lines above macro %{__rm} is used Fixed > - %{__chmod} -R u+w %{buildroot}/* > might be replaced with > %{_fixperms} %{buildroot}/* Used %{_fixperms} %{buildroot} Changes applied in CVS (1.119-12). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. -- Fedora Extras Perl SIG http://www.fedoraproject.org/wiki/Extras/SIGs/Perl perl-devel mailing list perl-devel@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/perl-devel
