[rpms/perl-Net-Amazon-S3] PR #2: Backport patch to make mutlipart uploads work

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



ppisar commented on the pull-request: `Backport patch to make mutlipart uploads work` that you are following:
``
Thanks for the patch. I slightly reworded the changes in spec file and applied to Fedora 39–36 and and EPEL 9.

I looked at EPEL 7 and there is Net-Amazon-S3-0.89 which is much different from 0.911: It has put_part() method which probably carries the two default arguments acl_short and copy_source using same-named roles of Net::Amazon::S3::Request::PutPart class. Those roles could be removed from the class. Regarding the is_xml_content(), the only similar check for XML content type is in _send_request().

Because I don't know anything about S3 and I don't have any account at Amazon to test it, I don't feel qualified to backport the patch to Net-Amazon-S3-0.89 in EPEL87 So I'm going to skip EPEL7. If you provide a tested patch, I'll be happy to apply it.

EPEL 7 was not updated to the latest Net-Amazon-S3 because 0.90 removed a documentation and 0.92 brought significant changes. There were also problems with tests which already in 0.89 required changes to work with other EPEL-7 packages. So unless somebody indicates that 0.89 does not work at all with current S3 servers, I'm hesitant to rebase it to the latest upstream version.

``

To reply, visit the link below
https://src.fedoraproject.org/rpms/perl-Net-Amazon-S3/pull-request/2
_______________________________________________
perl-devel mailing list -- perl-devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to perl-devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/perl-devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Announce]     [Fedora Kernel]     [Fedora Testing]     [Fedora Legacy Announce]     [Fedora PHP Devel]     [Kernel Devel]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite Information]

  Powered by Linux