[Bug 2172836] perl-Authen-Krb5: uses internal krb5 functions in example code, so build in C89 mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2172836

Florian Weimer <fweimer@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|2137512                     |2137516
                   |(PortingToModernCHelpNeeded |(PortingToModernCExemptions
                   |)                           |)
            Summary|perl-Authen-Krb5: uses      |perl-Authen-Krb5: uses
                   |internal krb5 functions in  |internal krb5 functions in
                   |example code                |example code, so build in
                   |                            |C89 mode



--- Comment #1 from Florian Weimer <fweimer@xxxxxxxxxx> ---
This now has been resolved on the krb5 side. The internal function calls are
not really required given the example has been written.

Unfortunately calls to krb5_free_enc_tkt_part and krb5_free_address remain. I
think both calls appear in contexts that are bit dubious, and crashes are only
avoided due to memory leaks.

When an Authen::Krb5::EncTktPart object is returned from
Authen::Krb5::Ticket::enc_part2, it would actually be required that this object
retains a reference to the original Authen::Krb5::Ticket object. Instead it
creates a new object with its own reference counter, and then papers over some
adverse effect with that krb5_free_enc_tkt_part call in
Authen::Krb5::EncTktPart::DESTROY.

The DESTROY method for Authen::Krb5::Address calls krb5_free_address. This
calls C free on the contents member, but that contents member is set to a
SvPV-allocated pointer in Authen::Krb5::Address::new.

I guess we have to build this in C89 mode to make these undeclared function
calls valid for now. I'll report these issues upstream as well.



Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2137512
[Bug 2137512] Porting Fedora to modern C: Bugs that need help
https://bugzilla.redhat.com/show_bug.cgi?id=2137516
[Bug 2137516] Porting Fedora to modern C: exemptions
-- 
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2172836
_______________________________________________
perl-devel mailing list -- perl-devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to perl-devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/perl-devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Announce]     [Fedora Kernel]     [Fedora Testing]     [Fedora Legacy Announce]     [Fedora PHP Devel]     [Kernel Devel]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite Information]

  Powered by Linux