[Bug 1781251] Unbundle flamegraph from perl-Devel-NYTProf

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1781251

Jerry James <loganjerry@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |iarnell@xxxxxxxxx,
                   |                            |jplesnik@xxxxxxxxxx,
                   |                            |perl-devel@lists.fedoraproj
                   |                            |ect.org
          Component|flamegraph                  |perl-Devel-NYTProf
            Version|31                          |rawhide
           Assignee|loganjerry@xxxxxxxxx        |jplesnik@xxxxxxxxxx
            Summary|flamegraph uses             |Unbundle flamegraph from
                   |/usr/bin/flamegraph.pl      |perl-Devel-NYTProf
                   |which conflicts with older  |
                   |package perl-Devel-NYTProf, |
                   |and should be renamed       |
           Doc Type|---                         |If docs needed, set a value



--- Comment #1 from Jerry James <loganjerry@xxxxxxxxx> ---
Actually, they are not different.  The flamegraph.pl in perl-Devel-NYTProf is a
bundled copy of Brendan Gregg's flamegraph, which is now shipped in Fedora in
the flamegraph package.  The correct fix to this issue is to unbundle
flamegraph from perl-Devel-NYTProf.  It looks like it should be easy.  Simply
remove %{buildroot}%{_bindir}/flamegraph.pl in %install, and add "Requires:
flamegraph" to the spec file.

The version in perl-Devel-NYTProf is a little older than the one in the
flamegraph package.  I have looked at the differences.  The version in the
flamegraph package has several bug fixes (mostly regarding Unicode characters
and SVG images) that are not fixed in the version in perl-Devel-NYTProf.  There
are a couple of backwards incompatible changes, but grep did not find any uses
of them in perl-Devel-NYTProf, so I believe that unbundling is safe.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
perl-devel mailing list -- perl-devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to perl-devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/perl-devel@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Announce]     [Fedora Kernel]     [Fedora Testing]     [Fedora Legacy Announce]     [Fedora PHP Devel]     [Kernel Devel]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Big List of Linux Books]     [Gimp]     [Yosemite Information]

  Powered by Linux