[Bug 1470030] perl-Test-LeakTrace-0.16-1.fc27 FTBFS: Failed test ' UninitCondition' on ppc64

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1470030

Mark Wielaard <mjw@xxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fweimer@xxxxxxxxxx



--- Comment #5 from Mark Wielaard <mjw@xxxxxxxxxxxxxxxxx> ---
Thanks for that. This indicates that the issue is in glibc at intl/dcigettext.c
around line 701 which is:

      /* If the current locale value is C (or POSIX) we don't load a
         domain.  Return the MSGID.  */
      if (strcmp (single_locale, "C") == 0
          || strcmp (single_locale, "POSIX") == 0)
        break;

And the undefined memory came from a stack allocation at the start of this
function. Which is probably this alloca:

single_locale = (char *) alloca (strlen (categoryvalue) + 1);

(Which isn't really at the start of the function, but I assume that is where
the compiler put it.)

It doesn't really make sense that this only triggers on ppc64. So I expect some
ppc64 specific instruction memory tracking is going wrong in valgrind/memcheck.

As far as I can see single_locale[0] is at least always defined just above this
test. As long as categoryvalue was well defined.

There were two recent changes to this code, although I don't think either of
them should have impacted this code path:

commit 9695dd0c9309712ed8e9c17a7040fe7af347f2dc
Author: Florian Weimer <fweimer@xxxxxxxxxx>
Date:   Wed Jun 21 16:31:31 2017 +0200

    DCIGETTEXT: Use getcwd, asprintf to construct absolute pathname

commit 37e9dc814636915afb88d0779e5e897e90e7b8c0
Author: Florian Weimer <fweimer@xxxxxxxxxx>
Date:   Mon Jun 19 14:44:33 2017 +0200

    DCIGETTEXT: Do not make copy of localename

Florian, I guess I should dig into the ppc64 code and see why memcheck is not
accurately tracking this. But since you recently touched this code is there any
possibility this code really be an undefined memory usage?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
perl-devel mailing list -- perl-devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to perl-devel-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Announce]     [Fedora Kernel]     [Fedora Testing]     [Fedora Legacy Announce]     [Fedora PHP Devel]     [Kernel Devel]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Big List of Linux Books]     [Gimp]     [Yosemite Information]

  Powered by Linux