https://bugzilla.redhat.com/show_bug.cgi?id=1458244 Bug ID: 1458244 Summary: [PATCH] - improve perl-Term-Completion handling of spaces Product: Fedora Version: rawhide Component: perl-Term-Completion Assignee: jplesnik@xxxxxxxxxx Reporter: tkasparek@xxxxxxxxxx QA Contact: extras-qa@xxxxxxxxxxxxxxxxx CC: jplesnik@xxxxxxxxxx, perl-devel@xxxxxxxxxxxxxxxxxxxxxxx Created attachment 1284412 --> https://bugzilla.redhat.com/attachment.cgi?id=1284412&action=edit patch which fixes the issue Description of problem: perl-Term-Completion does not handle spaces and tabs after the end of completed file very well. Version-Release number of selected component (if applicable): perl-Term-Completion-1.00-10.fc26 How reproducible: always Steps to Reproduce: 1. Enter file file? 2. /root[space][space][space][tab] 3. Ender file? /root substr outside of string at /usr/share/perl5/vendor_perl/Term/Completion.pm line 207, <STDIN> line 1. Use of uninitialized value $test in concatenation (.) or string at /usr/share/perl5/vendor_perl/Term/Completion.pm line 211, <STDIN> line 1. Actual results: Error message as shown in reproducer steps Expected results: No error Additional info: The error is caused when calculating the then length of substring to complete. In this case the length is negative, however it's accepted for completion as value of $add < 1 have boolean value of true. Accepting only positive values of $add fixes dais issue. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ perl-devel mailing list -- perl-devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to perl-devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
