[Bug 1305263] Review Request: perl-Text-Fuzzy - Partial string matching using edit distances

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1305263



--- Comment #3 from Denis Fateyev <denis@xxxxxxxxxxx> ---
(In reply to Petr Šabata from comment #1)
> * Missing builddeps: gcc, perl-devel

Added.

> * I'm not sure $LDFLAGS contains anything; consider using
> %{?__global_ldflags}.

In RHEL7 it contains not much though:
  # rpm -E '%{?__global_ldflags}'
  -Wl,-z,relro

Although the changed version should fit everything:
  export LDFLAGS="%{?__global_ldflags} -Wl,-z,now -Wl,--as-needed"

> * Consider packaging the examples directory as %doc.

Added.

> * And again, this module also technically requires Test::More 0.88+.  Don't
>   worry about it; I'm just mentioning it for completeness :)

Well, since epel7 has 0.98 (and Fedoras even newer) I initially dropped it; but
returned back for now.

Updated version:
Spec: http://www.fateyev.com/RPMS/Fedora22/perl-Text-Fuzzy.spec
SRPM: http://www.fateyev.com/RPMS/Fedora22/perl-Text-Fuzzy-0.24-2.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@xxxxxxxxxxxxxxxxxxxxxxx
http://lists.fedoraproject.org/admin/lists/perl-devel@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Announce]     [Fedora Kernel]     [Fedora Testing]     [Fedora Legacy Announce]     [Fedora PHP Devel]     [Kernel Devel]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Big List of Linux Books]     [Gimp]     [Yosemite Information]
  Powered by Linux