https://bugzilla.redhat.com/show_bug.cgi?id=1282911 --- Comment #5 from Petr Šabata <psabata@xxxxxxxxxx> --- I'll assume this is for Fedora only. * Missing a BR, as already pointed out in the other current reviews: - perl(integer), used in lib/Crypt/Salsa20.pm (lots) * strict and warnings are used in the Makefile.PL, too. You may want to list them in the top block, for consistence. Well, this depends on your style preference... * Drop META.json from %doc, it's of no use to your end users. * Package the license text using the %license macro. * If you really don't need EPEL compatibility, you can: 1) ignore the abovementioned coreutils & findutils point. 2) Add a 6.76+ version dependency constraint to EU::MM. 3) Generate the Makefile with `NO_PACKLIST=1'. This will allow you to drop line 46. * The Group tag is optional, too. -- You are receiving this mail because: You are on the CC list for the bug. -- Fedora Extras Perl SIG http://www.fedoraproject.org/wiki/Extras/SIGs/Perl perl-devel mailing list perl-devel@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/perl-devel@xxxxxxxxxxxxxxxxxxxxxxx
