Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492712 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> 2009-03-30 03:00:38 EDT --- Review: + package builds in mock (rawhide i586). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1264875 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 79463e02883f6d66018b371eea59c137 HTTP-Server-Simple-Static-0.07.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=3, Tests=5, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.26 cusr 0.03 csys = 0.31 CPU) + Package perl-HTTP-Server-Simple-Static-0.07-1.fc11.noarch => Provides: perl(HTTP::Server::Simple::Static) = 0.07 Requires: /usr/bin/perl perl(File::MMagic) perl(File::Spec::Functions) perl(HTTP::Server::Simple::Static) perl(IO::File) perl(MIME::Types) perl(URI::Escape) perl(base) perl(bytes) perl(lib) perl(strict) perl(warnings) Suggestions: 1) I think example.pl should be installed as %doc file. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. -- Fedora Extras Perl SIG http://www.fedoraproject.org/wiki/Extras/SIGs/Perl Fedora-perl-devel-list mailing list Fedora-perl-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-perl-devel-list
