Re: rpms/perl-Sort-Versions/devel perl-Sort-Versions.spec,1.9,1.10

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ralf,

On Thu, Mar 19, 2009 at 02:32:59PM +0100, Ralf Corsépius wrote:
>>  for f in Changes Versions.pm; do
>> -	iconv -f iso-8859-1 -t utf-8 <$f >${f}_ && mv ${f}_ $f
>> +	iconv -f iso-8859-1 -t utf-8 <$f >${f}_ &&
>> +	touch -r $f ${f}_ &&
>> +	mv ${f}_ $f
>>  done
>
>>  %changelog
>> +* Thu Mar 19 2009 Stepan Kasal <skasal@xxxxxxxxxx> - 1.5-11
>> +- fix timestamps of the recoded text files
>
> Why this change? Adjusting timestamps on perl modules is painting bikesheds.

OTOH, touching changelog during rpm build is not a good idea, so the
recode command should preserve the timestamp.

By fixing my recent commit, I made a note to self to do the
	iconv && touch && mv
right next type I'll use it somewhere.

(Hopefully, this thread will alse help me to remember better.)

I agree the importance of this change is close to 0, yet I think it
was not a mistake to cmmit it.

Stepan

--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
Fedora-perl-devel-list mailing list
Fedora-perl-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/fedora-perl-devel-list

[Index of Archives]     [Fedora Announce]     [Fedora Kernel]     [Fedora Testing]     [Fedora Legacy Announce]     [Fedora PHP Devel]     [Kernel Devel]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Big List of Linux Books]     [Gimp]     [Yosemite Information]
  Powered by Linux