Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485621 Chris Weyl <cweyl@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |cweyl@xxxxxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |cweyl@xxxxxxxxxxxxxxx Alias| |perl-Gtk2-MozEmbed Flag| |fedora-review? --- Comment #1 from Chris Weyl <cweyl@xxxxxxxxxxxxxxx> 2009-03-03 00:32:10 EDT --- rpmlint's warnings are expected for Perl packages; and while MozEmbed.so()(64bit) will need to be filtered, we're still figuring out the best way to do that over on fedora-perl-devel-list, so that's not a blocker right now. 1) MozEmbed.xs and other source files say LGPLv2+. 2) %check should be included, even if "make test" needs to be wrapped in some construct to prevent it from running in mock, e.g.: %{?_with_display_tests: make test} This will allow rebuilding locally using "rpmbuild --with display-tests" or defining "%_with_display_tests 1" in ~/.rpmmacros. 3) '%{__rm}' should be replaced with just 'rm', or make and chmod also need to be their macro representations. (Though I always prefer the %{_fixperms} chmod incantation :)) 4) %{perl_vendorarch}/Gtk2 and %{perl_vendorarch}/auto/Gtk2 need to be included as dirs in %files. One easy way to do so is: %{perl_vendorarch}/* %exclude %dir %{perl_vendorarch}/auto/ koji @ http://koji.fedoraproject.org/koji/taskinfo?taskID=1215907 Source tarball matches upstream: 23ffb8e4134ee8a8897149bf9db43d400cdbbe17 Gtk2-MozEmbed-0.08.tar.gz 23ffb8e4134ee8a8897149bf9db43d400cdbbe17 Gtk2-MozEmbed-0.08.tar.gz.srpm Provides, requires and rpmlint looks sane: =====> perl-Gtk2-MozEmbed-0.08-1.fc10.x86_64.rpm <===== ====> rpmlint perl-Gtk2-MozEmbed.x86_64: W: devel-file-in-non-devel-package /usr/lib64/perl5/vendor_perl/5.10.0/x86_64-linux-thread-multi/Gtk2/MozEmbed/Install/gtkmozembed2perl.h perl-Gtk2-MozEmbed.x86_64: W: devel-file-in-non-devel-package /usr/lib64/perl5/vendor_perl/5.10.0/x86_64-linux-thread-multi/Gtk2/MozEmbed/Install/gtkmozembed2perl-autogen.h 1 packages and 0 specfiles checked; 0 errors, 2 warnings. ====> provides for perl-Gtk2-MozEmbed-0.08-1.fc10.x86_64.rpm MozEmbed.so()(64bit) perl(Gtk2::MozEmbed) = 0.08 perl(Gtk2::MozEmbed::Install::Files) perl-Gtk2-MozEmbed = 0.08-1.fc10 perl-Gtk2-MozEmbed(x86-64) = 0.08-1.fc10 ====> requires for perl-Gtk2-MozEmbed-0.08-1.fc10.x86_64.rpm gecko-libs = 1.9.0.6 libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libcairo.so.2()(64bit) libdl.so.2()(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgthread-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libnspr4.so()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libplc4.so()(64bit) libplds4.so()(64bit) libpthread.so.0()(64bit) libpthread.so.0(GLIBC_2.2.5)(64bit) librt.so.1()(64bit) libxpcom.so()(64bit) libxul.so()(64bit) perl >= 0:5.008 perl(:MODULE_COMPAT_5.10.0) perl(DynaLoader) perl(Glib) >= 1.180 perl(Gtk2) perl(Gtk2) >= 1.081 perl(strict) perl(warnings) rtld(GNU_HASH) =====> perl-Gtk2-MozEmbed-debuginfo-0.08-1.fc10.x86_64.rpm <===== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides for perl-Gtk2-MozEmbed-debuginfo-0.08-1.fc10.x86_64.rpm perl-Gtk2-MozEmbed-debuginfo = 0.08-1.fc10 perl-Gtk2-MozEmbed-debuginfo(x86-64) = 0.08-1.fc10 ====> requires for perl-Gtk2-MozEmbed-debuginfo-0.08-1.fc10.x86_64.rpm Address #1-4 and I think we're in business :-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. -- Fedora Extras Perl SIG http://www.fedoraproject.org/wiki/Extras/SIGs/Perl Fedora-perl-devel-list mailing list Fedora-perl-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-perl-devel-list
