Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483016 --- Comment #3 from Jon Stanley <jonstanley@xxxxxxxxx> 2009-02-01 13:21:43 EDT --- Sorry for the delay, I'd intended to take care of this Friday night. But here it is. OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. SEE LATER - Meets Packaging Guidelines. OK - License OK - License field in spec matches Not included upstream - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: $ md5sum ../../build/SOURCES/perl-NOCpulse-Debug-1.23.13.tar.gz perl-NOCpulse-Debug-1.23.13.tar.gz b3d2897e6c4265561ce728568d2bce3d ../../build/SOURCES/perl-NOCpulse-Debug-1.23.13.tar.gz b3d2897e6c4265561ce728568d2bce3d perl-NOCpulse-Debug-1.23.13.tar.gz N/A - Package needs ExcludeArch OK - BuildRequires correct N/A - Spec handles locales/find_lang N/A - Package is relocatable and has a reason to be. OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) OK - Package is code or permissible content. N/A- Doc subpackage needed/used. No %doc files - Packages %doc files don't affect runtime. -- Please include the README from upstream here, and actually the full license N/A - Headers/static libs in -devel subpackage. N/A - Spec has needed ldconfig in post and postun N/A - .pc files in -devel subpackage/requires pkgconfig N/A - .so files in -devel subpackage. N/A - -devel package Requires: %{name} = %{version}-%{release} N/A - .la files are removed. N/A - Package is a GUI app and has a .desktop file OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. FAIL - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - No rpmlint output. - final provides and requires are sane: (include output of for i in *rpm; do echo $i; rpm -qp --provides $i; echo =; rpm -qp --requires $i; echo; done manually indented after checking each line. I also remove the rpmlib junk and anything provided by glibc.) perl-NOCpulse-Debug-1.23.13-1.fc11.noarch.rpm config(perl-NOCpulse-Debug) = 1.23.13-1.fc11 perl(NOCpulse::Debug) = 1.23 perl(NOCpulse::Debug::Stream) perl(NOCpulse::Debug::Stream::html) perl(NOCpulse::Debug::Stream::html_comment) perl(NOCpulse::Debug::Stream::literal) perl(NOCpulse::Debug::Stream::stdout) perl(NOCpulse::Debuggable) perl(NOCpulse::DependencyGraph) perl(NOCpulse::Log::LogManager) perl(NOCpulse::Log::Logger) perl(NOCpulse::Log::test::TestLogger) perl-NOCpulse-Debug = 1.23.13-1.fc11 = config(perl-NOCpulse-Debug) = 1.23.13-1.fc11 nocpulse-common perl(:MODULE_COMPAT_5.10.0) perl(Carp) perl(Class::MethodMaker) perl(Data::Dumper) perl(IO::Handle) perl(NOCpulse::Config) perl(NOCpulse::Debug) perl(NOCpulse::Log::LogManager) perl(NOCpulse::Log::Logger) SHOULD Items: OK, tested on x86_64 - Should build in mock. OK - Should build on all supported archs Didn't test - Should function as described. No scriptlets - Should have sane scriptlets. OK - Should have subpackages require base package with fully versioned depend. OK - Should have dist tag OK - Should package latest version N/A - check for outstanding bugs on package. (For core merge reviews) Please remove ownership of directories %{perl_vendorlib}/NOCpulse and ${_sysconfdir}/nocpulse. These are both owned by nocpulse-common, which you Require, and two packages can't own the same directories. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. -- Fedora Extras Perl SIG http://www.fedoraproject.org/wiki/Extras/SIGs/Perl Fedora-perl-devel-list mailing list Fedora-perl-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-perl-devel-list
