Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=466906 --- Comment #8 from Ralf Corsepius <rc040203@xxxxxxxxxx> 2009-01-29 09:48:29 EDT --- (In reply to comment #7) > > Requires(pre): perl(Class::MethodMaker) > > This is very likely wrong. > > OK. There it seems that pure > Requires: perl(Class::MethodMaker) > Should be ok. No, it's entirely superfluous, rpm adds it automatically. You can completely remove it. > > Please add perl-sig to InitialCC like most perl-packagers do. > I did not know it. I overlooked it in guidelines. Will do next time. > > > - "make test" is claimed to require "root". > > I recommend to add an rpm option to run this testsuite > All the test in this package require root. Hmm, sounds like a pretty severe design problem with this package to me. > So making them optional will be the > same as skipping it entirely. IMHO. Not at all. It would enable those who want to build rpms as "root" (likely you) to test your package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. -- Fedora Extras Perl SIG http://www.fedoraproject.org/wiki/Extras/SIGs/Perl Fedora-perl-devel-list mailing list Fedora-perl-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-perl-devel-list
