Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=472666 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flag| |fedora-review+ --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> 2008-11-23 05:07:14 EDT --- Review: + package builds in mock (development i386). koji build=> http://koji.fedoraproject.org/koji/taskinfo?taskID=946139 + rpmlint is silent for SRPM and for RPM. + source files match upstream url d5ca703d49ee23e85741d2da1dceeb31 DateTime-Format-Natural-0.73.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs All tests successful. Files=9, Tests=248, 8 wallclock secs ( 0.07 usr 0.00 sys + 3.93 cusr 0.07 csys = 4.07 CPU) + Package perl-DateTime-Format-Natural-0.73-1.fc11 => Provides: perl(DateTime::Format::Natural) = 0.73 perl(DateTime::Format::Natural::Base) = 1.15 perl(DateTime::Format::Natural::Lang::Base) = 0.9 perl(DateTime::Format::Natural::Lang::EN) = 1.12 Requires: /usr/bin/perl perl(Carp) perl(Date::Calc) perl(DateTime) perl(DateTime::Format::Natural) perl(Getopt::Long) perl(List::MoreUtils) perl(Params::Validate) perl(Term::ReadLine) perl(base) perl(boolean) perl(constant) perl(strict) perl(warnings) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. -- Fedora Extras Perl SIG http://www.fedoraproject.org/wiki/Extras/SIGs/Perl Fedora-perl-devel-list mailing list Fedora-perl-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-perl-devel-list
