Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462253 Jason Tibbitts <tibbs@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841 | Flag| |fedora-review+ --- Comment #5 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2008-11-05 20:56:38 EDT --- Yes, that's better, thanks. This package looks fine. Please go ahead and get your account set up, accept the CLA and apply for membership in the packager group. I will sponsor you. * source files match upstream: aa819d16345b537a88b539f5afe9a90b3ddf208a21ea5f89f0bc0850fe0a05d5 Cache-FastMmap-1.28.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: CImpl.so()(64bit) perl(Cache::FastMmap) = 1.28 perl(Cache::FastMmap::CImpl) = 1.28 perl-Cache-FastMmap = 1.28-2.fc10 perl-Cache-FastMmap(x86-64) = 1.28-2.fc10 = perl >= 0:5.006 perl(:MODULE_COMPAT_5.10.0) perl(Cache::FastMmap::CImpl) perl(XSLoader) perl(bytes) perl(constant) perl(strict) perl(warnings) * %check is present and all tests pass: All tests successful. Files=14, Tests=315, 23 wallclock secs ( 0.06 usr 0.02 sys + 4.30 cusr 0.67 csys = 5.05 CPU) * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la files. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. -- Fedora Extras Perl SIG http://www.fedoraproject.org/wiki/Extras/SIGs/Perl Fedora-perl-devel-list mailing list Fedora-perl-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-perl-devel-list
