Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Encode-Detect - Detects the encoding of data Alias: perl-Encode-Detect https://bugzilla.redhat.com/show_bug.cgi?id=250804 ruben@xxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED ------- Additional Comments From ruben@xxxxxxxxxxxxxxxx 2008-01-20 07:57 EST ------- I'm not a sponsor, but I can give some comments of course. You might want to do some reviews yourself, so possible future sponsors can get a feel of what your capable of, and sponsor you. Checklist: * source file matches upstream: 79b51d623e4a3a3b7d6583dfc5c3ec324fd98077 Encode-Detect-1.00.tar.gz * package is named according to the naming Guidelines * specfile is properly named, is cleanly written and uses macros consistently. * summaries are OK. * descriptions are OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. ? %clean is present. just a simple rm -rf $RPM_BUILD_ROOT will do * package builds fine in mock * package installs properly * rpmlint is silent * provides and requires are sane: [ruben@odin SRPMS]$ rpm -q --provides perl-Encode-Detect Detector.so perl(Encode::Detect) = 1.00 perl(Encode::Detect::Detector) = 1.00 perl-Encode-Detect = 1.00-3.fc8 [ruben@odin SRPMS]$ rpm -q --requires perl-Encode-Detect libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libstdc++.so.6(GLIBCXX_3.4) perl(:MODULE_COMPAT_5.8.8) perl(DynaLoader) perl(Encode) perl(Encode::Detect::Detector) perl(Encode::Encoding) perl(strict) perl(warnings) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(VersionedDependencies) <= 3.0.3-1 rtld(GNU_HASH) * %check is present and runs ok * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * code, not content. * documentation is small, so no -doc subpackage is necessary. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. -- Fedora Extras Perl SIG http://www.fedoraproject.org/wiki/Extras/SIGs/Perl Fedora-perl-devel-list mailing list Fedora-perl-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-perl-devel-list
