Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: ioctl default minimum argument length of 256 should be restored https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185242 jvdias@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jpo@xxxxxxxxxxxx, | |rgarciasuarez@xxxxxxxxxxxx ------- Additional Comments From jvdias@xxxxxxxxxx 2006-03-13 13:03 EST ------- Actually, I'm not sure the upstream patch is totally correct : # define IOCPARM_LEN(x) (_IOC_SIZE(x) < 256 ? 256 : _IOC_SIZE(x)) This ignores any non-zero _IOC_SIZE passed in if it is less than 256 ; why would the programmer pass in a non-zero _IOC_SIZE if it is not the size required ? I'm going to make it: # define IOCPARM_LEN(x) (_IOC_SIZE(x) ? _IOC_SIZE(x) : 256) which allows people to pass in a non-zero _IOC_SIZE that is less than 256, and will also fix the case where _IOC_SIZE is 0 and users depend on the default 256 length. Any objections ? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
