Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: amavisd-new https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=167354 tcallawa@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|gdk@xxxxxxxxxx |tcallawa@xxxxxxxxxx OtherBugsDependingO|163776 |163779 nThis| | ------- Additional Comments From tcallawa@xxxxxxxxxx 2006-01-16 23:21 EST ------- Since there are no obvious showstoppers in this bug ticket, I'll review this: Good: - rpmlint checks return: E: amavisd-new non-standard-uid /var/spool/amavisd/db amavis E: amavisd-new non-standard-gid /var/spool/amavisd/db amavis E: amavisd-new non-standard-dir-perm /var/spool/amavisd/db 0700 W: amavisd-new dangling-relative-symlink /usr/sbin/clamd.amavisd clamd E: amavisd-new non-standard-uid /var/spool/amavisd amavis E: amavisd-new non-standard-gid /var/spool/amavisd amavis E: amavisd-new non-standard-dir-perm /var/spool/amavisd 0700 E: amavisd-new non-standard-uid /var/run/amavisd amavis E: amavisd-new non-standard-gid /var/run/amavisd amavis E: amavisd-new non-standard-uid /var/spool/amavisd/tmp amavis E: amavisd-new non-standard-gid /var/spool/amavisd/tmp amavis E: amavisd-new non-standard-dir-perm /var/spool/amavisd/tmp 0700 E: amavisd-new init-script-name-with-dot /etc/rc.d/init.d/clamd.amavisd E: amavisd-new no-status-entry /etc/rc.d/init.d/clamd.amavisd W: amavisd-new no-reload-entry /etc/rc.d/init.d/clamd.amavisd E: amavisd-new subsys-not-used /etc/rc.d/init.d/clamd.amavisd E: amavisd-new incoherent-subsys /etc/rc.d/init.d/amavisd ${prog_base} I think all of these are safe to ignore. - package meets naming guidelines - package meets packaging guidelines - license (GPL) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
