Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Readonly-XS https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173053 paul@xxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|gdk@xxxxxxxxxx |paul@xxxxxxxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From paul@xxxxxxxxxxxx 2005-12-08 06:26 EST ------- Review: - rpmlint clean - package and spec naming OK - spec file written in English and is legible - sources match upstream - package builds OK on FC4 (i386) and in mock for rawhide (i386) - no locales, libraries, subpackages or pkgconfigs to worry about - not relocatable - no directory ownership or permissions problems - no duplicate files - code, not content - %clean section present and correct - macro usage is consistent - no large docs - docs don't affect runtime - no desktop entry needed - no scriptlets Needswork: - license is same as perl (i.e. GPL or Artistic), not just Artistic - redundant BR perl (listed in exceptions section of packaging guidelines) Suggestions: - minor change to %description: Readonly::XS is a companion module for Readonly, to speed up read-only scalar variables. Note: - version 1.04 of this module is now available, and presents a couple of issues if you're considering updating this package: * The "Requires: perl-Readonly = %{version}" won't be satisfied because there is no 1.04 version of perl-Readonly * The Makefile.PL introduces a buildreq on Readonly, which will be a circular dependency since your perl-Readonly package requires perl-Readonly-XS -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
