On Tue, 2005-10-04 at 06:28 +0200, Ralf Corsepius wrote:
> On Mon, 2005-10-03 at 23:22 +0300, Ville Skyttä wrote:
>
> > So, opinions, what should we do about it?
[...]
Ok, thanks for the comments.
So I'm planning to apply the attached patch for the next version, any
objections or suggestions? DESTDIR works properly since Perl 5.8.1 (or
actually ExtUtils::MakeMaker >= 6.10_08 AFAICT), it'd be more in line
with other packages out there than PERL_INSTALL_ROOT. No strong
opinions about that one though, I'll leave it out if someone doesn't
like the change.
? c.diff
Index: spectemplate-perl.spec
===================================================================
RCS file: /cvs/fedora/fedora-rpmdevtools/spectemplate-perl.spec,v
retrieving revision 1.10
diff -u -r1.10 spectemplate-perl.spec
--- spectemplate-perl.spec 9 Apr 2005 09:49:35 -0000 1.10
+++ spectemplate-perl.spec 4 Oct 2005 19:05:42 -0000
@@ -21,13 +21,13 @@
%build
-CFLAGS="$RPM_OPT_FLAGS" %{__perl} Makefile.PL INSTALLDIRS=vendor
-make %{?_smp_mflags} OPTIMIZE="$RPM_OPT_FLAGS"
+%{__perl} Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS"
+make %{?_smp_mflags}
%install
rm -rf $RPM_BUILD_ROOT
-make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
+make pure_install DESTDIR=$RPM_BUILD_ROOT
find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} ';'
find $RPM_BUILD_ROOT -type f -name '*.bs' -a -size 0 -exec rm -f {} ';'
find $RPM_BUILD_ROOT -type d -depth -exec rmdir {} 2>/dev/null ';'
